Skip to content

fix: deploy script validations #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2022
Merged

fix: deploy script validations #667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57a6a1e
fix: remove extra validation
abarmat Aug 1, 2022
a276503
fix: use yarn pre-deploy in migrate command
abarmat Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"build": "SKIP_LOAD=true scripts/build",
"clean": "rm -rf build/ cache/ dist/",
"compile": "hardhat compile",
"deploy": "yarn build && scripts/predeploy && hardhat migrate",
"deploy": "yarn build && yarn predeploy && hardhat migrate",
"deploy-localhost": "yarn deploy --force --network localhost --graph-config config/graph.localhost.yml",
"deploy-rinkeby": "yarn deploy --force --network rinkeby --graph-config config/graph.rinkeby.yml",
"deploy-goerli": "yarn deploy --force --network goerli --graph-config config/graph.goerli.yml",
Expand Down
4 changes: 0 additions & 4 deletions tasks/deployment/accounts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,6 @@ import { updateItemValue, writeConfig } from '../../cli/config'
task('migrate:accounts', '[localhost] Creates protocol accounts and saves them in graph config')
.addParam('graphConfig', cliOpts.graphConfig.description, cliOpts.graphConfig.default)
.setAction(async (taskArgs, hre) => {
if (hre.network.name !== 'localhost') {
throw new Error('This task can only be run on localhost network')
}

const { graphConfig, getDeployer } = hre.graph({
graphConfig: taskArgs.graphConfig,
})
Expand Down
4 changes: 0 additions & 4 deletions tasks/deployment/ownership.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ task(
.addParam('addressBook', cliOpts.addressBook.description, cliOpts.addressBook.default)
.addParam('graphConfig', cliOpts.graphConfig.description, cliOpts.graphConfig.default)
.setAction(async (taskArgs, hre) => {
if (hre.network.name !== 'localhost') {
throw new Error('This task can only be run on localhost network')
}

const { contracts, getNamedAccounts } = hre.graph({
addressBook: taskArgs.addressBook,
graphConfig: taskArgs.graphConfig,
Expand Down