Simplify GRE account logic #655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of changes to simplify GRE code:
Use hardhat's
SignerWithAddress
instead of our ownAccount
. This is the same account abstraction but widely used by hardhat so there is no point in redefining it.getNamedAccounts
will now always read the named account addresses from the graph config file and initialize aSignerWithAddress
. This will succeed regardless of wether we hold the private key/mnemonic for the account or not, so we can remove theVoidSigner
logic to further simplify. If we don't have the private key the signer simply won't be able to sign any transactions.