Simplify GRE account logic #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #655 +/- ##
=======================================
Coverage 90.35% 90.35%
=======================================
Files 35 35
Lines 1762 1762
Branches 296 296
=======================================
Hits 1592 1592
Misses 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
tmigone
force-pushed
the
tmigone/gre-accounts2
branch
from
ea54cd6 to
516e8d8
Compare
abarmat
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of changes to simplify GRE code:
Use hardhat's
SignerWithAddressinstead of our ownAccount. This is the same account abstraction but widely used by hardhat so there is no point in redefining it.getNamedAccountswill now always read the named account addresses from the graph config file and initialize aSignerWithAddress. This will succeed regardless of wether we hold the private key/mnemonic for the account or not, so we can remove theVoidSignerlogic to further simplify. If we don't have the private key the signer simply won't be able to sign any transactions.