Skip to content

feat: add account management methods to GRE #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Conversation

tmigone
Copy link
Member

@tmigone tmigone commented Jul 26, 2022

Motivation

This PR introduces yet more GRE changes which will come in handy in the future.

Changes

  • Split e2e tests into deployment config and init
  • Add account methods to GRE: getNamedAccounts, getTestAccounts and getDeployer
  • Add missing config to graph config file on goerli

Signed-off-by: Tomás Migone [email protected]

@tmigone tmigone force-pushed the tmigone/gre-accounts branch from 1a6e454 to 60cb15f Compare July 26, 2022 12:39
@tmigone tmigone force-pushed the tmigone/gre-accounts branch from 60cb15f to 5883005 Compare July 26, 2022 12:39
@tmigone tmigone force-pushed the tmigone/gre-accounts branch from 5883005 to 5604c86 Compare July 26, 2022 12:48
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #645 (6e68b48) into dev (bc6e119) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #645   +/-   ##
=======================================
  Coverage   90.29%   90.29%           
=======================================
  Files          35       35           
  Lines        1752     1752           
  Branches      293      293           
=======================================
  Hits         1582     1582           
  Misses        170      170           
Flag Coverage Δ
unittests 90.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc6e119...6e68b48. Read the comment docs.

abarmat
abarmat previously approved these changes Jul 27, 2022
Copy link
Contributor

@abarmat abarmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the improvements look great, only thing I find a bit odd is the test accounts mixed with the named ones.

@tmigone tmigone merged commit 842a8da into dev Jul 28, 2022
@tmigone tmigone deleted the tmigone/gre-accounts branch July 28, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants