Skip to content

fix: prevent underflow when subgraphs go under the minimum signal threshold #640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2022

Conversation

pcarranzav
Copy link
Member

@pcarranzav pcarranzav commented Jul 21, 2022

Depends on #569

@pcarranzav pcarranzav changed the base branch from pcv/rewards-supply-fixes to dev July 21, 2022 15:34
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #640 (0ec8778) into dev (7c6e27d) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #640      +/-   ##
==========================================
+ Coverage   90.35%   90.57%   +0.22%     
==========================================
  Files          35       35              
  Lines        1762     1762              
  Branches      296      296              
==========================================
+ Hits         1592     1596       +4     
+ Misses        170      166       -4     
Flag Coverage Δ
unittests 90.57% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/rewards/RewardsManager.sol 100.00% <100.00%> (+4.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6e27d...0ec8778. Read the comment docs.

@pcarranzav pcarranzav force-pushed the pcv/rewards-underflow branch from 22a9d94 to 9ac3b07 Compare July 28, 2022 15:15
@abarmat abarmat marked this pull request as ready for review August 2, 2022 18:15
Copy link
Contributor

@abarmat abarmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pcarranzav pcarranzav merged commit 69dcc9a into dev Sep 1, 2022
@pcarranzav pcarranzav deleted the pcv/rewards-underflow branch September 1, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants