Skip to content

CLI support for Arbitrum bridge + L2 rewards distribution #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Jul 27, 2022

Conversation

pcarranzav
Copy link
Member

@pcarranzav pcarranzav commented Apr 5, 2022

Following from #552, this PR adds support for some commands to configure and use the Arbitrum GRT bridge. We include commands to configure the bridge, and commands to send tokens from L1 to L2 and back from L2 to L1.

This PR temporarily targets the pcv/arb-bridge branch, until #552 is merged.

Edit: merged #571 onto this, so this now also includes the changes to support the new rewards distribution to L2.

@pcarranzav pcarranzav force-pushed the pcv/arb-bridge-cli branch 5 times, most recently from 9447437 to da9199b Compare April 12, 2022 15:36
@pcarranzav pcarranzav force-pushed the pcv/arb-bridge-cli branch 2 times, most recently from cf6d53f to e77fe37 Compare May 13, 2022 20:11
@pcarranzav pcarranzav force-pushed the pcv/arb-bridge-cli branch from e77fe37 to 12bac31 Compare May 17, 2022 18:13
@pcarranzav pcarranzav changed the base branch from pcv/arb-bridge to pcv/arb-bridge-callhooks May 17, 2022 18:19
@pcarranzav pcarranzav force-pushed the pcv/arb-bridge-callhooks branch from f6a86e4 to 70218ec Compare May 17, 2022 18:46
@pcarranzav pcarranzav force-pushed the pcv/arb-bridge-cli branch from 12bac31 to 053ef34 Compare May 17, 2022 18:48
@pcarranzav pcarranzav changed the title WIP: CLI support for Arbitrum bridge CLI support for Arbitrum bridge May 18, 2022
Base automatically changed from pcv/arb-bridge-callhooks to pcv/arb-bridge May 25, 2022 20:48
@pcarranzav pcarranzav force-pushed the pcv/arb-bridge-cli branch from 053ef34 to f5a5f24 Compare May 25, 2022 21:17
@pcarranzav pcarranzav force-pushed the pcv/arb-bridge-cli branch from f5a5f24 to 87f4bec Compare May 31, 2022 14:03
@pcarranzav pcarranzav force-pushed the pcv/arb-bridge-cli branch from 87f4bec to edbc3e0 Compare May 31, 2022 14:54
@pcarranzav pcarranzav marked this pull request as ready for review May 31, 2022 15:42
@pcarranzav
Copy link
Member Author

Marking this as ready for review, but we should merge #552 before this one.

@pcarranzav pcarranzav force-pushed the pcv/arb-bridge-cli branch 2 times, most recently from 795effd to 6f70096 Compare June 1, 2022 13:42
@codecov
Copy link

codecov bot commented Jun 1, 2022

Codecov Report

Merging #556 (8426b4c) into pcv/arb-bridge (061ab3f) will increase coverage by 0.60%.
The diff coverage is 99.59%.

@@                Coverage Diff                 @@
##           pcv/arb-bridge     #556      +/-   ##
==================================================
+ Coverage           91.32%   91.92%   +0.60%     
==================================================
  Files                  40       44       +4     
  Lines                1959     2080     +121     
  Branches              338      356      +18     
==================================================
+ Hits                 1789     1912     +123     
+ Misses                170      168       -2     
Flag Coverage Δ
unittests 91.92% <99.59%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/tests/ReservoirMock.sol 66.66% <66.66%> (ø)
contracts/gateway/BridgeEscrow.sol 100.00% <100.00%> (ø)
contracts/gateway/GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/gateway/L1GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/governance/Managed.sol 100.00% <100.00%> (+1.88%) ⬆️
contracts/l2/gateway/L2GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/l2/reservoir/L2Reservoir.sol 100.00% <100.00%> (ø)
contracts/l2/token/GraphTokenUpgradeable.sol 100.00% <100.00%> (ø)
contracts/l2/token/L2GraphToken.sol 100.00% <100.00%> (ø)
contracts/reservoir/L1Reservoir.sol 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 061ab3f...8426b4c. Read the comment docs.

We also add Goerli and Arbitrum Nitro Devnet configurations (though the CLI commands
don't support Nitro yet).
…-merge-552-fixes

This includes all the audit fixes on PR #552.
@pcarranzav pcarranzav changed the title CLI support for Arbitrum bridge CLI support for Arbitrum bridge + L2 rewards distribution Jul 27, 2022
@socket-security
Copy link

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
[email protected] (upgraded) binding.gyp package.json via [email protected], [email protected]
[email protected] (upgraded) binding.gyp package.json via [email protected], [email protected]
[email protected] (upgraded) binding.gyp package.json via [email protected], [email protected]
@arbitrum/[email protected] (added) postinstall package.json
[email protected] (upgraded) install package.json via [email protected], [email protected]
@swc/[email protected] (added) postinstall package.json via @arbitrum/[email protected], [email protected]
[email protected] (upgraded) install package.json via [email protected], [email protected]
[email protected] (upgraded) install package.json via [email protected], [email protected]
🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Package Location
[email protected] (upgraded) package.json via [email protected], [email protected]
[email protected] (upgraded) package.json via [email protected], [email protected]
[email protected] (upgraded) package.json via [email protected], [email protected]
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 8 new install scripts detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ⚠️ 3 new native modules detected

Powered by socket.dev

@pcarranzav pcarranzav merged commit 8426b4c into pcv/arb-bridge Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants