Skip to content

Audit: [N01] Lack of input validation #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Audit: [N01] Lack of input validation #518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/discovery/GNS.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ contract GNS is GNSV2Storage, GraphUpgradeable, IGNS, Multicall {

/**
* @dev Set the owner fee percentage. This is used to prevent a subgraph owner to drain all
* the name curators tokens while upgrading or deprecating and is configurable in parts per hundred.
* the name curators tokens while upgrading or deprecating and is configurable in parts per million.
* @param _ownerTaxPercentage Owner tax percentage
*/
function setOwnerTaxPercentage(uint32 _ownerTaxPercentage) external override onlyGovernor {
Expand All @@ -181,7 +181,7 @@ contract GNS is GNSV2Storage, GraphUpgradeable, IGNS, Multicall {

/**
* @dev Internal: Set the owner tax percentage. This is used to prevent a subgraph owner to drain all
* the name curators tokens while upgrading or deprecating and is configurable in parts per hundred.
* the name curators tokens while upgrading or deprecating and is configurable in parts per million.
* @param _ownerTaxPercentage Owner tax percentage
*/
function _setOwnerTaxPercentage(uint32 _ownerTaxPercentage) private {
Expand Down