[release/v1.16] Backport go 1.24.11 and x/crypto update #4708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simonswine
commented
Dec 23, 2025
simonswine
commented
- Update golang version to 1.24.11
- chore: Patch golang.org/x/crypto/ssh
simonswine
requested review from
a team,
aleks-p and
marcsanmi
as code owners
simonswine
changed the title
simonswine
changed the title
marcsanmi
approved these changes
Dec 23, 2025
Contributor
|
Just seen this, sorry. Should we update the toolchain as well? Line 5 in 6555bf9 |
Contributor
Author
|
Toolchain doesn't make a difference to what we release, if you care then let's PR it into main and backport: https://github.com/grafana/pyroscope/blob/main/go.mod |
Contributor
Author
|
Probably best to include it into: https://github.com/grafana/pyroscope/blob/main/tools/upgrade-go-version.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.