[tempo] allow opt-in appProtocol on service ports #4050
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some L7 gateways (e.g. gRPC via Cilium Gateway) require appProtocol (e.g. kubernetes.io/h2c) to correctly route HTTP/2 cleartext traffic. Expose appProtocol as an optional setting for the gRPC Service ports. Signed-off-by: Patrick Bardo <[email protected]>
pattybardo
requested review from
a team,
BitProcessor,
Sheikh-Abubaker,
dgzlopes,
faustodavid and
swartz-k
as code owners
|
|
pattybardo
changed the title
Author
|
Lint-test looks like it needs a fix: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some L7 gateways (e.g. gRPC via Cilium Gateway) require appProtocol (e.g. kubernetes.io/h2c) to correctly route HTTP/2 cleartext traffic. Expose appProtocol as an optional setting for the gRPC Service ports.