Skip to content

[pdc-agent] Expose token secret key name in values #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
holgerjh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[pdc-agent] Expose token secret key name in values #4018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d243a2
[pdc-agent] Expose token secret key name in values
holgerjh Nov 24, 2025
e61af3a
Merge branch 'main' into feat/expose-token-secret-keyname-in-values
dafydd-t Dec 5, 2025
e818418
Merge branch 'main' into feat/expose-token-secret-keyname-in-values
dafydd-t Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/pdc-agent/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: pdc-agent
description: PDC agent is an agent for connecting to Grafana Private Data source Connect
type: application
appVersion: "0.0.45"
version: 0.0.4
version: 0.1.0
home: https://grafana.com/docs/grafana-cloud/connect-externally-hosted/private-data-source-connect/
sources:
- https://github.com/grafana/pdc-agent
5 changes: 3 additions & 2 deletions charts/pdc-agent/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# pdc-agent

![Version: 0.0.4](https://img.shields.io/badge/Version-0.0.4-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.0.45](https://img.shields.io/badge/AppVersion-0.0.45-informational?style=flat-square)
![Version: 0.1.0](https://img.shields.io/badge/Version-0.1.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.0.45](https://img.shields.io/badge/AppVersion-0.0.45-informational?style=flat-square)

PDC agent is an agent for connecting to Grafana Private Data source Connect

Expand Down Expand Up @@ -46,7 +46,8 @@ PDC agent is an agent for connecting to Grafana Private Data source Connect
| serviceAccount.create | bool | `false` | Toggle to create ServiceAccount |
| serviceAccount.labels | object | `{}` | Labels applied to created service account |
| serviceAccount.name | string | `"pdc-agent"` | Service account name |
| tokenSecretName | string | `""` | secretName Expects a secret with key `token` which contains the Access Policy token you generated |
| tokenSecretKey | string | `"token"` | tokenSecretKey Defines the key that is used to lookup the token value in the secret defined by `tokenSecretName`. |
| tokenSecretName | string | `""` | tokenSecretName Expects a secret which contains the Access Policy token you generated. See `tokenSecretKey` for the key name under which the value is expected. |
| tolerations | list | `[]` | not required, but left in as a choice |

----------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion charts/pdc-agent/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ spec:
valueFrom:
secretKeyRef:
name: {{ required "A secret name for the PDC agent token is required" .Values.tokenSecretName }}
key: token
key: {{ required "A secret key for the PDC agent token is required" .Values.tokenSecretKey | quote }}
{{- else if .Values.insecureTokenValue }}
value: {{ .Values.insecureTokenValue | quote }}
{{- else }}
Expand Down
4 changes: 3 additions & 1 deletion charts/pdc-agent/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,10 @@ debug: false
cluster: ""
# -- The numeric ID of your Hosted Grafana stack
hostedGrafanaId: ""
# -- secretName Expects a secret with key `token` which contains the Access Policy token you generated
# -- tokenSecretName Expects a secret which contains the Access Policy token you generated. See `tokenSecretKey` for the key name under which the value is expected.
tokenSecretName: ""
# -- tokenSecretKey Defines the key that is used to lookup the token value in the secret defined by `tokenSecretName`.
tokenSecretKey: "token"
# -- insecureTokenValue is used to set the token value directly in the deployment.yaml file. This is useful for testing purposes.
insecureTokenValue: ""

Expand Down
Loading