Skip to content

deps: update collector to 0.125.0 #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 6, 2025
Merged

Conversation

dsotirakis
Copy link
Collaborator

Updates otel collector to 0.125.0

Skipped 0.124.0 due to open-telemetry/opentelemetry-collector#12907

@dsotirakis dsotirakis self-assigned this May 5, 2025
@dsotirakis dsotirakis marked this pull request as ready for review May 5, 2025 14:10
@dsotirakis dsotirakis requested a review from a team as a code owner May 5, 2025 14:10
@dsotirakis dsotirakis enabled auto-merge (squash) May 5, 2025 15:12
Copy link
Contributor

@guicaulada guicaulada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed lot's of formatting changes to workflows, and some code changes to .go files, are all these intended and part of the 0.125.0 update?

I assume the receivertest.NopType is now a required argument for receivertest.NewNopSettings but other changes like the generated_logs.go feel like a new feature added to the receiver and generated_metrics.go feel like a logic change since the scope name will be dynamic now, if I understand correctly?

@dsotirakis dsotirakis force-pushed the update-collector-to-0.125.0 branch from d64aa2c to 9a2efcd Compare May 6, 2025 07:36
@dsotirakis
Copy link
Collaborator Author

I noticed lot's of formatting changes to workflows

Hm, I could only see single to double quote changes, which I reverted anyway in d4b26d0.

but other changes like the generated_logs.go feel like a new feature added to the receiver

well this comes as part of this issue which now comes as a default if logs are enabled.

logic change since the scope name will be dynamic now

logic doesn't change, since what was in there before is now replaced by the var ScopeName which is hardcoded in generated_status.go.

@dsotirakis dsotirakis requested review from guicaulada and a team May 6, 2025 08:00
@dsotirakis dsotirakis merged commit 33c6f82 into main May 6, 2025
12 checks passed
@dsotirakis dsotirakis deleted the update-collector-to-0.125.0 branch May 6, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants