-
Notifications
You must be signed in to change notification settings - Fork 164
[Prometheus] More resource attribute promotion #897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Promote more resource attributes: * `host.name`: host monitoring * `k8s.node.name`: K8s node oriented view when doing K8s monitoring * `postgresql.*` resource attributes used by otelcol/receiver/postgresql * `database`: resource attribute used by otelcol/receiver/mongodb * `kafka.cluster.alias`: resource attribute used by otelcol/receiver/kafkametrics Signed-off-by: Cyrille Le Clerc <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Gregor Zeitlinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR promotes additional OpenTelemetry resource attributes to Prometheus labels in the LGTM observability stack. The changes expand monitoring capabilities for host-level metrics, Kubernetes node monitoring, and database-specific metrics from PostgreSQL, MongoDB, and Kafka receivers.
- Adds
host.nameandk8s.node.namefor infrastructure monitoring - Adds PostgreSQL-specific resource attributes (
postgresql.database.name,postgresql.schema.name,postgresql.table.name,postgresql.index.name) - Adds
databaseattribute for MongoDB receiver andkafka.cluster.aliasfor Kafka metrics - Adds
deployment.environmentfor backward compatibility alongsidedeployment.environment.name
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zeitlinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
Co-authored-by: Copilot <[email protected]> Signed-off-by: Gregor Zeitlinger <[email protected]>
Signed-off-by: Gregor Zeitlinger <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@cyrille-leclerc please sign the CLA |
Promote more resource attributes:
host.name: host monitoringk8s.node.name: K8s node oriented view when doing K8s monitoringpostgresql.*resource attributes used by otelcol/receiver/postgresqldatabase: resource attribute used by otelcol/receiver/mongodbkafka.cluster.alias: resource attribute used by otelcol/receiver/kafkametrics