Fix container labels #853
Merged
Fix container labels #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove `build-date`, which is wrong, and rely on `org.opencontainers.image.created` instead. - Specify `org.opencontainers.image.revision` as it is not always correct.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances Docker image metadata by adding standard OCI annotations and cleaning up inherited labels from the base image.
- Adds
org.opencontainers.image.revisionlabel containing the git SHA to both release workflows - Blanks out the
build-datelabel inherited from the base image to maintain consistency with other cleaned-up base image labels
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker/Dockerfile | Adds build-date="" to the list of base image labels being blanked out |
| .github/workflows/release.yml | Adds org.opencontainers.image.revision OCI standard label with git SHA |
| .github/workflows/ghcr-image-build-and-publish.yml | Adds org.opencontainers.image.revision OCI standard label with git SHA |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zeitlinger
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-date, which is wrong, and rely onorg.opencontainers.image.createdinstead.org.opencontainers.image.revisionas it is not always correct.See #837 (comment).