Skip to content

Conversation

@martincostello
Copy link
Member

@martincostello martincostello commented Aug 28, 2025

Refactor the .NET example to detect #734.

Resolves #734.

Testing if this identifies the issue in #734.


Signed-off-by: Martin Costello <[email protected]>
Only configure OTLP once, and get values from environment variables not configuration.
Fix typo in container names.
@martincostello
Copy link
Member Author

Verified locally that the tests fail if I downgrade the OpenTelemetry Collector to v0.133.0.

@martincostello martincostello marked this pull request as ready for review September 4, 2025 09:58
Copilot AI review requested due to automatic review settings September 4, 2025 09:58
@martincostello martincostello enabled auto-merge (squash) September 4, 2025 09:59
@martincostello martincostello merged commit 4a596ea into main Sep 4, 2025
42 checks passed
@martincostello martincostello deleted the gh-734 branch September 4, 2025 10:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Refactors the .NET example to use standard OpenTelemetry environment variables for OTLP configuration instead of custom configuration, changing from gRPC (port 4317) to HTTP/protobuf (port 4318) protocol.

  • Replaces custom Otlp__Endpoint configuration with standard OTEL_EXPORTER_OTLP_ENDPOINT environment variable
  • Switches from gRPC protocol (port 4317) to HTTP/protobuf protocol (port 4318)
  • Simplifies code by using UseOtlpExporter() extension method instead of manual OTLP exporter configuration

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
examples/dotnet/docker-compose.yml Updates environment variables to use standard OTLP configuration with HTTP protocol
examples/dotnet/docker-compose.oats.yml Updates environment variables to use standard OTLP configuration with HTTP protocol
examples/dotnet/appsettings.json Removes custom Otlp configuration section
examples/dotnet/Program.cs Simplifies OpenTelemetry setup using UseOtlpExporter() and removes manual OTLP configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP/protobuf Metrics not working in v0.11.9

2 participants