Add integration test for OTLP internal metrics #2058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thampiotr
approved these changes
Nov 14, 2024
vaxvms
pushed a commit
to vaxvms/alloy
that referenced
this pull request
Nov 15, 2024
* add integration test for OTLP internal metrics * rename otel gen app
vaxvms
pushed a commit
to vaxvms/alloy
that referenced
this pull request
Nov 20, 2024
* add integration test for OTLP internal metrics * rename otel gen app
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Alloy v1.4.0 some Otel metrics were renamed but we forgot to rename them in the k8s-monitoring helm-chart. This broke some user dashboards. (see grafana/k8s-monitoring-helm#840)
This test will ensure that the internal otel metrics are available.
It's also adding traces to the otel gen app + tempo in the docker compose. This is helpful when setting up a local lab to test configs.