Skip to content

feat: support icons in testname format #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kdkasad wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: support icons in testname format #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2a1c24
feat: support icons in testname format
kdkasad Aug 1, 2025
949ca83
test: add unit tests for testname format with icons
kdkasad Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmd/handler_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,9 @@ func TestEventHandler_Event_WithMissingActionFail(t *testing.T) {

buf := new(bufferCloser)
errBuf := new(bytes.Buffer)
format := testjson.NewEventFormatter(errBuf, "testname", testjson.FormatOptions{})
format := testjson.NewEventFormatter(errBuf, "testname", testjson.FormatOptions{
Icons: "text",
})

source := golden.Get(t, "../../testjson/testdata/input/go-test-json-missing-test-fail.out")
cfg := testjson.ScanConfig{
Expand Down
4 changes: 4 additions & 0 deletions cmd/main_e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ func TestE2E_RerunFails(t *testing.T) {
name: "reruns until success",
args: []string{
"-f=testname",
"--format-icons=text",
"--rerun-fails=4",
"--packages=./testdata/e2e/flaky/",
"--", "-count=1", "-tags=testdata",
Expand All @@ -85,6 +86,7 @@ func TestE2E_RerunFails(t *testing.T) {
name: "reruns continues to fail",
args: []string{
"-f=testname",
"--format-icons=text",
"--rerun-fails=2",
"--packages=./testdata/e2e/flaky/",
"--", "-count=1", "-tags=testdata",
Expand All @@ -95,6 +97,7 @@ func TestE2E_RerunFails(t *testing.T) {
name: "first run has errors, abort rerun",
args: []string{
"-f=testname",
"--format-icons=text",
"--rerun-fails=2",
"--packages=../testjson/internal/broken",
"--", "-count=1", "-tags=stubpkg",
Expand Down Expand Up @@ -254,6 +257,7 @@ func TestE2E_IgnoresWarnings(t *testing.T) {
"--rerun-fails=1",
"--packages=./testdata/e2e/ignore_warnings/",
"--format=testname",
"--format-icons=text",
"--", "-tags=testdata", "-cover", "-coverpkg=./cmd/internal",
}
assert.NilError(t, flags.Parse(args))
Expand Down
8 changes: 4 additions & 4 deletions cmd/testdata/e2e/expected/TestE2E_IgnoresWarnings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
=== RUN TestIgnoreWarnings
--- FAIL: TestIgnoreWarnings
FAIL cmd/testdata/e2e/ignore_warnings.TestIgnoreWarnings
FAIL cmd/testdata/e2e/ignore_warnings.TestIgnoreWarnings
coverage: [no statements]
FAIL cmd/testdata/e2e/ignore_warnings
FAIL cmd/testdata/e2e/ignore_warnings

DONE 1 tests, 1 failure

=== RUN TestIgnoreWarnings
--- FAIL: TestIgnoreWarnings
FAIL cmd/testdata/e2e/ignore_warnings.TestIgnoreWarnings (re-run 1)
FAIL cmd/testdata/e2e/ignore_warnings.TestIgnoreWarnings (re-run 1)
coverage: [no statements]
FAIL cmd/testdata/e2e/ignore_warnings
FAIL cmd/testdata/e2e/ignore_warnings

=== Failed
=== FAIL: cmd/testdata/e2e/ignore_warnings TestIgnoreWarnings
Expand Down
2 changes: 1 addition & 1 deletion cmd/testdata/e2e/expected/TestE2E_RerunFails/first_run_has_errors,_abort_rerun
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FAIL testjson/internal/broken
FAIL testjson/internal/broken

=== Failed
=== FAIL: testjson/internal/broken
Expand Down
2 changes: 1 addition & 1 deletion cmd/testdata/e2e/expected/TestE2E_RerunFails/first_run_has_errors,_abort_rerun-go1.23
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FAIL testjson/internal/broken
FAIL testjson/internal/broken

=== Failed
=== FAIL: testjson/internal/broken
Expand Down
38 changes: 19 additions & 19 deletions cmd/testdata/e2e/expected/TestE2E_RerunFails/reruns_continues_to_fail
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,54 +1,54 @@
PASS cmd/testdata/e2e/flaky.TestAlwaysPasses
PASS cmd/testdata/e2e/flaky.TestAlwaysPasses
=== RUN TestFailsRarely
SEED: 0
flaky_test.go:51: not this time
--- FAIL: TestFailsRarely
FAIL cmd/testdata/e2e/flaky.TestFailsRarely
FAIL cmd/testdata/e2e/flaky.TestFailsRarely
=== RUN TestFailsSometimes
SEED: 0
flaky_test.go:58: not this time
--- FAIL: TestFailsSometimes
FAIL cmd/testdata/e2e/flaky.TestFailsSometimes
PASS cmd/testdata/e2e/flaky.TestFailsOften/subtest_always_passes
FAIL cmd/testdata/e2e/flaky.TestFailsSometimes
PASS cmd/testdata/e2e/flaky.TestFailsOften/subtest_always_passes
=== RUN TestFailsOften/subtest_may_fail
flaky_test.go:68: not this time
--- FAIL: TestFailsOften/subtest_may_fail
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail
=== RUN TestFailsOften
SEED: 0
--- FAIL: TestFailsOften
FAIL cmd/testdata/e2e/flaky.TestFailsOften
PASS cmd/testdata/e2e/flaky.TestFailsOftenDoesNotPrefixMatch
PASS cmd/testdata/e2e/flaky.TestFailsSometimesDoesNotPrefixMatch
FAIL cmd/testdata/e2e/flaky
FAIL cmd/testdata/e2e/flaky.TestFailsOften
PASS cmd/testdata/e2e/flaky.TestFailsOftenDoesNotPrefixMatch
PASS cmd/testdata/e2e/flaky.TestFailsSometimesDoesNotPrefixMatch
FAIL cmd/testdata/e2e/flaky

DONE 8 tests, 4 failures

PASS cmd/testdata/e2e/flaky.TestFailsRarely (re-run 1)
PASS cmd/testdata/e2e/flaky
PASS cmd/testdata/e2e/flaky.TestFailsSometimes (re-run 1)
PASS cmd/testdata/e2e/flaky
PASS cmd/testdata/e2e/flaky.TestFailsRarely (re-run 1)
PASS cmd/testdata/e2e/flaky
PASS cmd/testdata/e2e/flaky.TestFailsSometimes (re-run 1)
PASS cmd/testdata/e2e/flaky
=== RUN TestFailsOften/subtest_may_fail
flaky_test.go:68: not this time
--- FAIL: TestFailsOften/subtest_may_fail
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 1)
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 1)
=== RUN TestFailsOften
SEED: 3
--- FAIL: TestFailsOften
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 1)
FAIL cmd/testdata/e2e/flaky
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 1)
FAIL cmd/testdata/e2e/flaky

DONE 2 runs, 12 tests, 6 failures

=== RUN TestFailsOften/subtest_may_fail
flaky_test.go:68: not this time
--- FAIL: TestFailsOften/subtest_may_fail
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 2)
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 2)
=== RUN TestFailsOften
SEED: 4
--- FAIL: TestFailsOften
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 2)
FAIL cmd/testdata/e2e/flaky
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 2)
FAIL cmd/testdata/e2e/flaky

=== Failed
=== FAIL: cmd/testdata/e2e/flaky TestFailsRarely
Expand Down
38 changes: 19 additions & 19 deletions cmd/testdata/e2e/expected/TestE2E_RerunFails/reruns_continues_to_fail-go1.23
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,54 +1,54 @@
PASS cmd/testdata/e2e/flaky.TestAlwaysPasses
PASS cmd/testdata/e2e/flaky.TestAlwaysPasses
=== RUN TestFailsRarely
SEED: 0
flaky_test.go:51: not this time
--- FAIL: TestFailsRarely
FAIL cmd/testdata/e2e/flaky.TestFailsRarely
FAIL cmd/testdata/e2e/flaky.TestFailsRarely
=== RUN TestFailsSometimes
SEED: 0
flaky_test.go:58: not this time
--- FAIL: TestFailsSometimes
FAIL cmd/testdata/e2e/flaky.TestFailsSometimes
PASS cmd/testdata/e2e/flaky.TestFailsOften/subtest_always_passes
FAIL cmd/testdata/e2e/flaky.TestFailsSometimes
PASS cmd/testdata/e2e/flaky.TestFailsOften/subtest_always_passes
=== RUN TestFailsOften/subtest_may_fail
flaky_test.go:68: not this time
--- FAIL: TestFailsOften/subtest_may_fail
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail
=== RUN TestFailsOften
SEED: 0
--- FAIL: TestFailsOften
FAIL cmd/testdata/e2e/flaky.TestFailsOften
PASS cmd/testdata/e2e/flaky.TestFailsOftenDoesNotPrefixMatch
PASS cmd/testdata/e2e/flaky.TestFailsSometimesDoesNotPrefixMatch
FAIL cmd/testdata/e2e/flaky
FAIL cmd/testdata/e2e/flaky.TestFailsOften
PASS cmd/testdata/e2e/flaky.TestFailsOftenDoesNotPrefixMatch
PASS cmd/testdata/e2e/flaky.TestFailsSometimesDoesNotPrefixMatch
FAIL cmd/testdata/e2e/flaky

DONE 8 tests, 4 failures

PASS cmd/testdata/e2e/flaky.TestFailsRarely (re-run 1)
PASS cmd/testdata/e2e/flaky
PASS cmd/testdata/e2e/flaky.TestFailsSometimes (re-run 1)
PASS cmd/testdata/e2e/flaky
PASS cmd/testdata/e2e/flaky.TestFailsRarely (re-run 1)
PASS cmd/testdata/e2e/flaky
PASS cmd/testdata/e2e/flaky.TestFailsSometimes (re-run 1)
PASS cmd/testdata/e2e/flaky
=== RUN TestFailsOften/subtest_may_fail
flaky_test.go:68: not this time
--- FAIL: TestFailsOften/subtest_may_fail
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 1)
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 1)
=== RUN TestFailsOften
SEED: 3
--- FAIL: TestFailsOften
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 1)
FAIL cmd/testdata/e2e/flaky
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 1)
FAIL cmd/testdata/e2e/flaky

DONE 2 runs, 12 tests, 6 failures

=== RUN TestFailsOften/subtest_may_fail
flaky_test.go:68: not this time
--- FAIL: TestFailsOften/subtest_may_fail
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 2)
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 2)
=== RUN TestFailsOften
SEED: 4
--- FAIL: TestFailsOften
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 2)
FAIL cmd/testdata/e2e/flaky
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 2)
FAIL cmd/testdata/e2e/flaky

=== Failed
=== FAIL: cmd/testdata/e2e/flaky TestFailsRarely
Expand Down
50 changes: 25 additions & 25 deletions cmd/testdata/e2e/expected/TestE2E_RerunFails/reruns_until_success
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,72 +1,72 @@
PASS cmd/testdata/e2e/flaky.TestAlwaysPasses
PASS cmd/testdata/e2e/flaky.TestAlwaysPasses
=== RUN TestFailsRarely
SEED: 0
flaky_test.go:51: not this time
--- FAIL: TestFailsRarely
FAIL cmd/testdata/e2e/flaky.TestFailsRarely
FAIL cmd/testdata/e2e/flaky.TestFailsRarely
=== RUN TestFailsSometimes
SEED: 0
flaky_test.go:58: not this time
--- FAIL: TestFailsSometimes
FAIL cmd/testdata/e2e/flaky.TestFailsSometimes
PASS cmd/testdata/e2e/flaky.TestFailsOften/subtest_always_passes
FAIL cmd/testdata/e2e/flaky.TestFailsSometimes
PASS cmd/testdata/e2e/flaky.TestFailsOften/subtest_always_passes
=== RUN TestFailsOften/subtest_may_fail
flaky_test.go:68: not this time
--- FAIL: TestFailsOften/subtest_may_fail
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail
=== RUN TestFailsOften
SEED: 0
--- FAIL: TestFailsOften
FAIL cmd/testdata/e2e/flaky.TestFailsOften
PASS cmd/testdata/e2e/flaky.TestFailsOftenDoesNotPrefixMatch
PASS cmd/testdata/e2e/flaky.TestFailsSometimesDoesNotPrefixMatch
FAIL cmd/testdata/e2e/flaky
FAIL cmd/testdata/e2e/flaky.TestFailsOften
PASS cmd/testdata/e2e/flaky.TestFailsOftenDoesNotPrefixMatch
PASS cmd/testdata/e2e/flaky.TestFailsSometimesDoesNotPrefixMatch
FAIL cmd/testdata/e2e/flaky

DONE 8 tests, 4 failures

PASS cmd/testdata/e2e/flaky.TestFailsRarely (re-run 1)
PASS cmd/testdata/e2e/flaky
PASS cmd/testdata/e2e/flaky.TestFailsSometimes (re-run 1)
PASS cmd/testdata/e2e/flaky
PASS cmd/testdata/e2e/flaky.TestFailsRarely (re-run 1)
PASS cmd/testdata/e2e/flaky
PASS cmd/testdata/e2e/flaky.TestFailsSometimes (re-run 1)
PASS cmd/testdata/e2e/flaky
=== RUN TestFailsOften/subtest_may_fail
flaky_test.go:68: not this time
--- FAIL: TestFailsOften/subtest_may_fail
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 1)
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 1)
=== RUN TestFailsOften
SEED: 3
--- FAIL: TestFailsOften
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 1)
FAIL cmd/testdata/e2e/flaky
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 1)
FAIL cmd/testdata/e2e/flaky

DONE 2 runs, 12 tests, 6 failures

=== RUN TestFailsOften/subtest_may_fail
flaky_test.go:68: not this time
--- FAIL: TestFailsOften/subtest_may_fail
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 2)
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 2)
=== RUN TestFailsOften
SEED: 4
--- FAIL: TestFailsOften
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 2)
FAIL cmd/testdata/e2e/flaky
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 2)
FAIL cmd/testdata/e2e/flaky

DONE 3 runs, 14 tests, 8 failures

=== RUN TestFailsOften/subtest_may_fail
flaky_test.go:68: not this time
--- FAIL: TestFailsOften/subtest_may_fail
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 3)
FAIL cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 3)
=== RUN TestFailsOften
SEED: 5
--- FAIL: TestFailsOften
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 3)
FAIL cmd/testdata/e2e/flaky
FAIL cmd/testdata/e2e/flaky.TestFailsOften (re-run 3)
FAIL cmd/testdata/e2e/flaky

DONE 4 runs, 16 tests, 10 failures

PASS cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 4)
PASS cmd/testdata/e2e/flaky.TestFailsOften (re-run 4)
PASS cmd/testdata/e2e/flaky
PASS cmd/testdata/e2e/flaky.TestFailsOften/subtest_may_fail (re-run 4)
PASS cmd/testdata/e2e/flaky.TestFailsOften (re-run 4)
PASS cmd/testdata/e2e/flaky

=== Failed
=== FAIL: cmd/testdata/e2e/flaky TestFailsRarely
Expand Down
Loading