dots-v2: fix jitteriness, again #388
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had some previous fixes: * gotestyourself#368 * gotestyourself#354 These do not fully fix the problem, only mask the issues. The real issues arise when there are 100s of packages to display, but only so much screen space. As each one bounces around, the text is entirely unreadable. The previous approaches was to more effieciently update the lines to make it more incremental. The approach here is different - simple but extremely effective. Instead of trying to constantly write out the entire set of lines/packages under test, on each event, we keep track of a active and completed set of packages. Once a package is completed, we write it out one last time, and then never overwrite it. The active set is treated as we do today. This means if we have 8 core machine and 1000 packages, we are only updating 8 lines at a time, which removes all jitteriness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This had some previous fixes:
These do not fully fix the problem, only mask the issues.
The real issues arise when there are 100s of packages to display, but only so much screen space. As each one bounces around, the text is entirely unreadable. The previous approaches was to more effieciently update the lines to make it more incremental.
The approach here is different - simple but extremely effective. Instead of trying to constantly write out the entire set of lines/packages under test, on each event, we keep track of a active and completed set of packages.
Once a package is completed, we write it out one last time, and then never overwrite it. The active set is treated as we do today.
This means if we have 8 core machine and 1000 packages, we are only updating 8 lines at a time, which removes all jitteriness.
The current PR totally breaks windows. If there is desire to move forward I can try to get it working on windows, but I don't have a windows machine so its a struggle for me