Skip to content

Conversation

@aberthet-gpsw
Copy link
Contributor

When in a story with multiple scenes using omnitone/ambisonic sounds the library is initialized at each scene on the first time we visit them and if we revisit them again it throws an error.

This PR fixes this problem.

@bbaudel bbaudel added the wip label Oct 13, 2017
@sw-team-release-gpsw
Copy link

sw-team-release-gpsw commented Nov 15, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 4 committers have signed the CLA.

✅ undefined
❌ aberthet-gpsw
❌ Benjamin Baudel
❌ benjamin


Benjamin Baudel, benjamin seem not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@bbaudel bbaudel requested a review from rroux-gpsw November 15, 2017 16:18
@bbaudel
Copy link
Contributor

bbaudel commented Nov 15, 2017

Still WIP status.

  • Works well with image scene with background sound between scenes
  • Works well with videos scenes with ambisonics
  • Don't work when reaching a video scene after an image scene which contains ambisonics as scene sound

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants