Skip to content

Conversation

go-wyvern
Copy link
Member

@go-wyvern go-wyvern commented May 21, 2025

@go-wyvern go-wyvern closed this May 21, 2025
@go-wyvern go-wyvern reopened this May 21, 2025
@go-wyvern go-wyvern changed the title fix(ast): improve End method in CallExpr to handle valid Rparen fix(compile): ensure valid Rparen and NoParenEnd in CallExpr May 22, 2025
Copy link

qiniu-x bot commented May 22, 2025

[Git-flow] Hi @go-wyvern, There are some suggestions for your information:


Rebase suggestions

  • Following commits have duplicated messages

    fix(ast): update NoParenEnd in compileBranchStmt to use correct label end position

    fix(ast): update NoParenEnd in compileBranchStmt to use correct label end position

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

@xushiwei xushiwei merged commit 6674a0c into goplus:main May 22, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LS panic due to slice bounds out of range
2 participants