-
Notifications
You must be signed in to change notification settings - Fork 3
docs: compare the design difference with llcppg #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Documentation Review: llpyg vs llcppg Design DifferencesI've completed a comprehensive review of the documentation comparing llpyg and llcppg design differences. Here's my feedback: ✅ Strengths
|
Summary of ChangesHello @toaction, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求新增了一份文档,详细比较了 llpyg 和 llcppg 这两个项目在设计上的主要差异。这份文档旨在帮助用户和开发者理解这两个工具如何根据其各自的目标语言(Python 和 C/C++)在符号信息获取、类型处理、配置文件和整体架构方面采取不同的实现策略。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
这篇文档清晰地对比了 llpyg
和 llcppg
在设计上的差异,对理解这两个工具非常有帮助。我发现了一些可以改进的地方,主要涉及文档中的代码示例准确性和描述的精确性。具体来说,一个 JSON 示例存在格式错误,一个 Go 代码示例中的类型与描述不符,以及对配置文件字段作用的解释可以更精确一些。修正这些小问题将有助于提高文档的质量和准确性。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation review with specific improvement suggestions. The document provides a good comparison between llpyg and llcppg, but there are some grammatical issues and areas where clarity can be improved.
Implementation for #23