[WIP]feat:support isolated python runtime for building #1237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeteorsLiu
reviewed
Aug 29, 2025
internal/pyenv/pybuild.go
Outdated
Comment on lines
117
to
122
| for _, p := range parts { | ||
| if p == pkgcfg { | ||
| found = true | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
It's better to replace with slices.Contains
MeteorsLiu
reviewed
Aug 29, 2025
| return err | ||
| } | ||
| lines := strings.Split(string(b), "\n") | ||
| rpath := "-Wl,-rpath," + filepath.Join(pyHome, "lib") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
internal/pyenvllgo build, automatically download a Python environment intoLLGoCache, pip corresponding site-packages, and set up the runtime.Current issues:
llgo runandllgo build. When running the binary, the program falls back to the system’s default Python.