[WIP]feat: support llpkg for building #1213
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeteorsLiu
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1213 +/- ##
==========================================
- Coverage 87.94% 87.83% -0.11%
==========================================
Files 32 38 +6
Lines 7657 7837 +180
==========================================
+ Hits 6734 6884 +150
- Misses 844 865 +21
- Partials 79 88 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MeteorsLiu
changed the title
test: fix special module path test test: fix zip test test: fix assert url test test: add ghrelease test test: remove unused test codes test: add more tests about failure case test: add more tests for module version test: add tests for module version in installer test: add tests for pcgen test: optimize tests test: add more tests for pcgen
MeteorsLiu
force-pushed
the
support-llpkg
branch
from
78e4d73 to
5a9e896
Compare
Comment on lines
+672
to
+676
| if runtime.GOOS == "darwin" { | ||
| buildArgs = append(buildArgs, "-Wl,-t", "-Wl,-map,symbol.map") | ||
| } else { | ||
| buildArgs = append(buildArgs, "-Wl,--Map=symbol.map") | ||
| } |
There was a problem hiding this comment.
the generated symbol.map file might be misunderstood as a build artifact, especially since we haven't established where debug outputs should go yet.
| // InstallBinary installs a binary package using the default GitHub release installer. | ||
| // It takes an LLPkgConfig containing package information and an output directory path. | ||
| // Returns any error encountered during the installation process. | ||
| func InstallBinary(llpkgConfig LLPkgConfig, outputDir string) error { |
There was a problem hiding this comment.
InstallBinary may lead some misunderstand.beacuse the artifacts of llpkg also have the pc file.
internal/llpkg/installer/fetch.go
Outdated
| // The caller is responsible for cleaning up the temporary file when no longer needed. | ||
| func DownloadFile(url, outputDir string) (fileName string, err error) { | ||
| // make sure path exists | ||
| if err := os.MkdirAll(outputDir, 0700); err != nil { |
MeteorsLiu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrited version of #1048.
There's too many historical codes in #1048, have to refine.
Design: https://github.com/goplus/llpkgstore/blob/main/docs/llpkgstore.md