Fix variable anchors when DesignSpace source specifies a layer #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The anchor position was always taken from the default layer, ignoring the specified layerName.
The DesignSpace document has a source that uses Medium layer, but before the previous fix the anchor position was taken from the default layer.
khaledhosny
force-pushed
the
anchors-source-layer
branch
from
d35af4c to
ab1ed09
Compare
Member
|
good catch! this is basically the continuation of #840 but for the sparse UFO layers @khaledhosny can you please also test that my assumption in googlefonts/fontmake#1090 (comment) is true? |
Member
I just tried to remove the anchor "top" from the intermediate glyph "e" in the LayerFont.ufo's "Medium" layer used for the VF integration tests and indeed the intermediate glyph is skipped when producing the mark2base lookup. feature mark {
lookup mark2base {
pos base e
- <anchor (wght=350:314 wght=450:403 wght=625:315) (wght=350:556 wght=450:567 wght=625:644)> mark @MC_top;
+ <anchor (wght=350:314 wght=625:315) (wght=350:556 wght=625:644)> mark @MC_top;
} mark2base;
} mark; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The anchor position was always taken from the default layer, ignoring the specified layerName.