Skip to content

Conversation

@hongalex
Copy link
Member

@hongalex hongalex commented Dec 5, 2025

PiperOrigin-RevId: 840720260

PiperOrigin-RevId: 840720260
@hongalex hongalex requested review from a team as code owners December 5, 2025 20:48
@product-auto-label product-auto-label bot added the api: maintenance Issues related to the Unified Maintenance API. label Dec 5, 2025
@snippet-bot
Copy link

snippet-bot bot commented Dec 5, 2025

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hongalex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Maintenance API client by integrating version 1 (v1) of the API. This feature enables developers to utilize the latest iteration of the Maintenance service with dedicated Go client libraries, offering enhanced functionality and stability. The changes involve adding new API definitions, generated client code, and example usage, ensuring a complete and ready-to-use client for the v1 API.

Highlights

  • Introduction of Maintenance API v1: The pull request adds support for version 1 of the Maintenance API, alongside the existing v1beta, expanding the service's capabilities.
  • New Go Client Libraries: Comprehensive Go client libraries and associated generated code have been added for the Maintenance API v1, including protobufs, gRPC stubs, and client implementations to facilitate interaction with the new API version.
  • Updated Configuration: The .librarian/state.yaml file has been updated to reflect the new API version and its corresponding file structure within the repository, ensuring proper build and release processes.
  • Code Snippets and Examples: New code snippets and example tests are included for various v1 API methods like GetLocation, GetResourceMaintenance, ListLocations, ListResourceMaintenances, and SummarizeMaintenances, providing clear usage guidance.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Go client for the Maintenance API v1. The changes consist of auto-generated code, including the client library, protobuf definitions, and usage snippets. My review focuses on improving the documentation by correcting a couple of typos in the generated comments, which will enhance clarity for developers using this new client.

Comment on lines +253 to +254
// - `maintenance.maitenanceName="eb3b709c-9ca1-5472-9fb6-800a3849eda1" AND
// maintenanceCompleteTime>"2000-10-11T20:44:51Z"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the example filter: maitenanceName should be maintenanceName. The suggested change also removes the markdown backticks from the example.

Suggested change
// - `maintenance.maitenanceName="eb3b709c-9ca1-5472-9fb6-800a3849eda1" AND
// maintenanceCompleteTime>"2000-10-11T20:44:51Z"`
// - maintenance.maintenanceName="eb3b709c-9ca1-5472-9fb6-800a3849eda1" AND
// maintenanceCompleteTime>"2000-10-11T20:44:51Z"

// The Maintenance API provides a centralized view of planned disruptive
// maintenance events across supported Google Cloud products. It offers users
// visibility into upcoming, ongoing, and completed maintenance, along with
// controls to manage certain maintenance activities, such as mainteance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the package documentation. mainteance should be maintenance.

Suggested change
// controls to manage certain maintenance activities, such as mainteance
// controls to manage certain maintenance activities, such as maintenance

@hongalex hongalex merged commit 8eba8b8 into googleapis:main Dec 5, 2025
9 checks passed
@hongalex hongalex deleted the librarian-onboard-maintenance branch December 5, 2025 21:43
JoeWang1127 pushed a commit that referenced this pull request Dec 11, 2025
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v0.0.0-20251120153138-6e4de1e6ca60
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:718167d5c23ed389b41f617b3a00ac839bdd938a6bd2d48ae0c2f1fa51ab1c3d
<details><summary>aiplatform: 1.111.0</summary>

##
[1.111.0](aiplatform/v1.110.0...aiplatform/v1.111.0)
(2025-12-11)

### Features

* add streaming function call argument API changes (PiperOrigin-RevId:
842549490)
([21c9dbf](21c9dbfb))

### Bug Fixes

* fix issue when using UrlContext tool (PiperOrigin-RevId: 840347639)
([21c9dbf](21c9dbfb))

### Documentation

* A comment for field `name` in message
`.google.cloud.aiplatform.v1.FunctionCall` is changed
(PiperOrigin-RevId: 842549490)
([21c9dbf](21c9dbfb))

* A comment for field `args` in message
`.google.cloud.aiplatform.v1.FunctionCall` is changed
(PiperOrigin-RevId: 842549490)
([21c9dbf](21c9dbfb))

</details>


<details><summary>compute: 1.51.0</summary>

##
[1.51.0](compute/v1.50.0...compute/v1.51.0)
(2025-12-11)

### Features

* Update Compute Engine v1 API to revision 20251031
([21c9dbf](21c9dbfb))

* Update Compute Engine v1beta API to revision 20251031
([21c9dbf](21c9dbfb))

</details>


<details><summary>maintenance: 0.2.0</summary>

##
[0.2.0](maintenance/v0.1.2...maintenance/v0.2.0)
(2025-12-11)

### Features

* add Gemini TTS Multispeaker API fields (#12925) (PiperOrigin-RevId:
809186275)
([1364374](13643749))

* add new clients (#13448) (PiperOrigin-RevId: 840720260)
([8eba8b8](8eba8b82))

</details>


<details><summary>run: 1.13.0</summary>

##
[1.13.0](run/v1.12.1...run/v1.13.0)
(2025-12-11)

### Features

* add SourceCode proto to Run container config (PiperOrigin-RevId:
840919560)
([21c9dbf](21c9dbfb))

### Documentation

* A comment for field `items` in message
`.google.cloud.run.v2.SecretVolumeSource` is changed (PiperOrigin-RevId:
840919560)
([21c9dbf](21c9dbfb))

* A comment for field `name` in message `.google.cloud.run.v2.Service`
is changed (PiperOrigin-RevId: 840919560)
([21c9dbf](21c9dbfb))

* A comment for field `observed_generation` in message
`.google.cloud.run.v2.WorkerPool` is changed (PiperOrigin-RevId:
840919560)
([21c9dbf](21c9dbfb))

* A comment for field `etag` in message
`.google.cloud.run.v2.WorkerPool` is changed (PiperOrigin-RevId:
840919560)
([21c9dbf](21c9dbfb))

* A comment for field `reconciling` in message
`.google.cloud.run.v2.WorkerPool` is changed (PiperOrigin-RevId:
840919560)
([21c9dbf](21c9dbfb))

* A comment for field `invoker_iam_disabled` in message
`.google.cloud.run.v2.Service` is changed (PiperOrigin-RevId: 840919560)
([21c9dbf](21c9dbfb))

* A comment for field `latest_ready_revision` in message
`.google.cloud.run.v2.WorkerPool` is changed (PiperOrigin-RevId:
840919560)
([21c9dbf](21c9dbfb))

* A comment for field `etag` in message `.google.cloud.run.v2.Service`
is changed (PiperOrigin-RevId: 840919560)
([21c9dbf](21c9dbfb))

* A comment for field `custom_audiences` in message
`.google.cloud.run.v2.WorkerPool` is changed (PiperOrigin-RevId:
840919560)
([21c9dbf](21c9dbfb))

* A comment for field `limits` in message
`.google.cloud.run.v2.ResourceRequirements` is changed
(PiperOrigin-RevId: 840919560)
([21c9dbf](21c9dbfb))

* A comment for field `etag` in message `.google.cloud.run.v2.Job` is
changed (PiperOrigin-RevId: 840919560)
([21c9dbf](21c9dbfb))

</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: maintenance Issues related to the Unified Maintenance API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants