chore: librarian update image pull request: 20251112T170525Z

[quartzmo]

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:c4bb601f466f857040028f81c47ecf808034fcf8463166320f80be761653d167

[gemini-code-assist]

Summary of Changes

Hello @quartzmo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request encompasses a routine update of the librarian-go image and significant enhancements to various Google Cloud client libraries. The primary functional change is the introduction of a 'returnPartialSuccess' query parameter for 'ListOperations' calls, enabling more flexible handling of long-running operations. Additionally, it includes refactoring of internal routing header logic in some clients and the enablement of hard-bound tokens for MTLS_S2A, contributing to improved client behavior and security.

Highlights

• Librarian Image Update: The core librarian-go image has been updated to a new SHA256 hash, indicating a new version or build of the underlying tool.
• New Query Parameter for ListOperations: A new query parameter, 'returnPartialSuccess', has been added to numerous 'ListOperations' REST client calls across various Google Cloud client libraries (e.g., AI Generative Language, AI Platform, AlloyDB, API Hub, Data Catalog, Dialogflow, Discovery Engine, Document AI, etc.). This allows clients to request partial success responses for long-running operations.
• Routing Header Refactoring: The logic for generating routing headers in the Cloud Build v2 client and Firestore Admin client has been refactored to use a more robust slice-based approach with a 'seen' map, replacing previous string concatenation and map-based methods. This improves how request parameters like 'location', 'project_id', and 'database_id' are handled.
• MTLS_S2A Hard-Bound Token Support: Several client libraries, including Asset, BigQuery, Cloud Tasks, Dataflow, Error Reporting, Essential Contacts, and Firestore, now explicitly allow hard-bound tokens for MTLS_S2A (Mutual TLS with Secure Session Association) through a new internal option.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request appears to be an automated dependency update from Librarian. It introduces several changes across a large number of files, including updating the builder image, adding a returnPartialSuccess parameter to many ListOperations methods, and enabling MTLS_S2A for several clients.

The PR also refactors how routing headers are constructed in some clients. While the new approach is an improvement, I've noticed a recurring performance issue in the generated code where regular expressions are compiled inside functions on every call. This is inefficient. I've added a few comments with suggestions to optimize this by compiling the regex once and reusing the result. These suggestions should be applied to all similar occurrences to improve performance.

[gemini-code-assist]

This block can be made more efficient. regexp.MustCompile is a relatively expensive operation and is being called on every function invocation. For better performance, the compiled regular expression should be defined as a package-level variable.

Additionally, the regular expression is evaluated multiple times against req.GetParent(). This can be optimized by calling FindStringSubmatch once and reusing its result.

A similar pattern of inefficiency is present in other functions within this file that construct routing headers. Applying this feedback across all of them would be beneficial.

	reg := regexp.MustCompile("projects/[^/]+/locations/(?P<location>[^/]+)")
	if matches := reg.FindStringSubmatch(req.GetParent()); len(matches) > 1 && len(url.QueryEscape(matches[1])) > 0 {
		if !seen["location"] {
			routingHeaders = append(routingHeaders, fmt.Sprintf("%s=%s", "location", url.QueryEscape(matches[1])))
			seen["location"] = true
		}
	}

[gemini-code-assist]

This block has some performance inefficiencies. regexp.MustCompile is called multiple times within this block, and for each regex, FindStringSubmatch is also called multiple times. For better performance, compiled regular expressions should be defined as package-level variables to avoid recompilation on every call.

Also, req.GetPitrSnapshot().GetDatabase() is called repeatedly, and the regex matching can be simplified to a single FindStringSubmatch call per regex, checking the length of the result.

Here's a suggested refactoring. This feedback also applies to the REST client implementation of this method later in the file.

Suggested change

	var routingHeaders []string
	seen := make(map[string]bool)
	if reg := regexp.MustCompile("projects/(?P<project_id>[^/]+)(?:/.*)?"); reg.MatchString(req.GetPitrSnapshot().GetDatabase()) && len(url.QueryEscape(reg.FindStringSubmatch(req.GetPitrSnapshot().GetDatabase())[1])) > 0 {
	routingHeadersMap["project_id"] = url.QueryEscape(reg.FindStringSubmatch(req.GetPitrSnapshot().GetDatabase())[1])
	if !seen["project_id"] {
	routingHeaders = append(routingHeaders, fmt.Sprintf("%s=%s", "project_id", url.QueryEscape(reg.FindStringSubmatch(req.GetPitrSnapshot().GetDatabase())[1])))
	seen["project_id"] = true
	}
	}
	if reg := regexp.MustCompile("projects/[^/]+/databases/(?P<database_id>[^/]+)(?:/.*)?"); reg.MatchString(req.GetPitrSnapshot().GetDatabase()) && len(url.QueryEscape(reg.FindStringSubmatch(req.GetPitrSnapshot().GetDatabase())[1])) > 0 {
	routingHeadersMap["database_id"] = url.QueryEscape(reg.FindStringSubmatch(req.GetPitrSnapshot().GetDatabase())[1])
	}
	for headerName, headerValue := range routingHeadersMap {
	routingHeaders = fmt.Sprintf("%s%s=%s&", routingHeaders, headerName, headerValue)
	if !seen["database_id"] {
	routingHeaders = append(routingHeaders, fmt.Sprintf("%s=%s", "database_id", url.QueryEscape(reg.FindStringSubmatch(req.GetPitrSnapshot().GetDatabase())[1])))
	seen["database_id"] = true
	}
	}
	var routingHeaders []string
	seen := make(map[string]bool)
	databasePath := req.GetPitrSnapshot().GetDatabase()
	regProject := regexp.MustCompile("projects/(?P<project_id>[^/]+)(?:/.*)?")
	if matches := regProject.FindStringSubmatch(databasePath); len(matches) > 1 && len(url.QueryEscape(matches[1])) > 0 {
	if !seen["project_id"] {
	routingHeaders = append(routingHeaders, fmt.Sprintf("%s=%s", "project_id", url.QueryEscape(matches[1])))
	seen["project_id"] = true
	}
	}
	regDatabase := regexp.MustCompile("projects/[^/]+/databases/(?P<database_id>[^/]+)(?:/.*)?")
	if matches := regDatabase.FindStringSubmatch(databasePath); len(matches) > 1 && len(url.QueryEscape(matches[1])) > 0 {
	if !seen["database_id"] {
	routingHeaders = append(routingHeaders, fmt.Sprintf("%s=%s", "database_id", url.QueryEscape(matches[1])))
	seen["database_id"] = true
	}
	}

[gemini-code-assist]

This block has the same performance inefficiencies as its gRPC counterpart earlier in the file. regexp.MustCompile is called multiple times, and for each regex, FindStringSubmatch is also called multiple times. For better performance, compiled regular expressions should be defined as package-level variables.

The regex matching can be simplified to a single FindStringSubmatch call per regex, checking the length of the result.

Suggested change

	var routingHeaders []string
	seen := make(map[string]bool)
	if reg := regexp.MustCompile("projects/(?P<project_id>[^/]+)(?:/.*)?"); reg.MatchString(req.GetPitrSnapshot().GetDatabase()) && len(url.QueryEscape(reg.FindStringSubmatch(req.GetPitrSnapshot().GetDatabase())[1])) > 0 {
	routingHeadersMap["project_id"] = url.QueryEscape(reg.FindStringSubmatch(req.GetPitrSnapshot().GetDatabase())[1])
	if !seen["project_id"] {
	routingHeaders = append(routingHeaders, fmt.Sprintf("%s=%s", "project_id", url.QueryEscape(reg.FindStringSubmatch(req.GetPitrSnapshot().GetDatabase())[1])))
	seen["project_id"] = true
	}
	}
	if reg := regexp.MustCompile("projects/[^/]+/databases/(?P<database_id>[^/]+)(?:/.*)?"); reg.MatchString(req.GetPitrSnapshot().GetDatabase()) && len(url.QueryEscape(reg.FindStringSubmatch(req.GetPitrSnapshot().GetDatabase())[1])) > 0 {
	routingHeadersMap["database_id"] = url.QueryEscape(reg.FindStringSubmatch(req.GetPitrSnapshot().GetDatabase())[1])
	}
	for headerName, headerValue := range routingHeadersMap {
	routingHeaders = fmt.Sprintf("%s%s=%s&", routingHeaders, headerName, headerValue)
	if !seen["database_id"] {
	routingHeaders = append(routingHeaders, fmt.Sprintf("%s=%s", "database_id", url.QueryEscape(reg.FindStringSubmatch(req.GetPitrSnapshot().GetDatabase())[1])))
	seen["database_id"] = true
	}
	}
	var routingHeaders []string
	seen := make(map[string]bool)
	databasePath := req.GetPitrSnapshot().GetDatabase()
	regProject := regexp.MustCompile("projects/(?P<project_id>[^/]+)(?:/.*)?")
	if matches := regProject.FindStringSubmatch(databasePath); len(matches) > 1 && len(url.QueryEscape(matches[1])) > 0 {
	if !seen["project_id"] {
	routingHeaders = append(routingHeaders, fmt.Sprintf("%s=%s", "project_id", url.QueryEscape(matches[1])))
	seen["project_id"] = true
	}
	}
	regDatabase := regexp.MustCompile("projects/[^/]+/databases/(?P<database_id>[^/]+)(?:/.*)?")
	if matches := regDatabase.FindStringSubmatch(databasePath); len(matches) > 1 && len(url.QueryEscape(matches[1])) > 0 {
	if !seen["database_id"] {
	routingHeaders = append(routingHeaders, fmt.Sprintf("%s=%s", "database_id", url.QueryEscape(matches[1])))
	seen["database_id"] = true
	}
	}

[shollyman]

Lots of LRO updates, LGTM

[gemini-code-assist]

Summary of Changes

Hello @quartzmo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request includes several updates to the codebase. It updates the librarian image, adds a new token option to gRPC clients, includes the returnPartialSuccess parameter for REST clients, and refactors routing headers in the Cloud Build API client.

Highlights

• Image Update: The librarian image has been updated to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:c4bb601f466f857040028f81c47ecf808034fcf8463166320f80be761653d167.
• gRPC Client Options: Added internaloption.AllowHardBoundTokens("MTLS_S2A") to gRPC client options in multiple API clients.
• REST Client Updates: Modified numerous REST client files to include returnPartialSuccess parameter in ListOperations.
• Routing Headers: Refactored routing headers in cloudbuild/apiv1/v2/cloud_build_client.go to use a list instead of string concatenation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request primarily updates a librarian image in state.yaml and introduces a new returnPartialSuccess query parameter in various Go API client files. Additionally, there are minor refactorings in the cloudbuild and firestore clients to improve how routing headers are constructed, making the code more robust against duplicate parameters. An internal authentication option AllowHardBoundTokens("MTLS_S2A") was also added to some client options. Overall, the changes appear to be routine updates and minor code improvements, with no immediate critical or high-severity issues identified.