Skip to content

Conversation

@cloud-sdk-librarian-robot
Copy link
Collaborator

BEGIN_COMMIT_OVERRIDE

BEGIN_NESTED_COMMIT
fix: upgrade gRPC service registration func
An update to Go gRPC Protobuf generation will change service registration function signatures to use an interface instead of a concrete type in generated .pb.go service files. This change should affect very few client library users. See release notes advisories in #11025.

PiperOrigin-RevId: 817164257
Library-IDs: errorreporting
Source-link: googleapis/googleapis@9215671d
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: automated code change

PiperOrigin-RevId: 802074437
Library-IDs: errorreporting
Source-link: googleapis/googleapis@c850d956
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
chore: update copyright year for auto-generated protos

PiperOrigin-RevId: 732130682
Library-IDs: errorreporting
Source-link: googleapis/googleapis@9415ba04
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: Updates documentation with regional resource names for multiple requests

PiperOrigin-RevId: 652832022
Library-IDs: errorreporting
Source-link: googleapis/googleapis@72b72389
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
docs: Removes references as a "global-only" service

PiperOrigin-RevId: 652832022
Library-IDs: errorreporting
Source-link: googleapis/googleapis@72b72389
END_NESTED_COMMIT

BEGIN_NESTED_COMMIT
chore: update copyright year for auto-generated protos

PiperOrigin-RevId: 631538781
Library-IDs: errorreporting
Source-link: googleapis/googleapis@3597f7db
END_NESTED_COMMIT

END_COMMIT_OVERRIDE

This pull request is generated with proto changes between
googleapis/googleapis@4221b78e
(exclusive) and
googleapis/googleapis@9215671d
(inclusive).

Librarian Version: v0.0.0-20251022181450-0ee9437f0ec3
Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:496591304b0d24ab57ea5f2c8a7870921713edab7f6fd002c5b2e78a8d6de396

Generation failed for

  • spanner

@cloud-sdk-librarian-robot
Copy link
Collaborator Author

One or more libraries have failed to generate, please review PR description for a list of failed libraries.
For each failed library, open a ticket in that library’s repository and then you may resolve this comment and merge.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @cloud-sdk-librarian-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a series of automated updates to the Google Cloud Error Reporting Go client library. The changes encompass an upgrade to gRPC service registration, an update of the protobuf generation toolchain, and the addition of new iterator patterns tailored for Go 1.23+. Furthermore, internal client logic has been refactored for better maintainability, API calls now include default timeouts, and documentation has been enhanced for clarity on regional resources and service behavior.

Highlights

  • gRPC Service Registration Upgrade: The gRPC service registration function signatures have been updated to use an interface instead of a concrete type in generated .pb.go service files. This is a significant internal refactoring to align with modern Go gRPC practices.
  • Protobuf Generation Tooling Update: The protoc-gen-go and protoc versions used for generating protobuf code have been upgraded to v1.35.2 and v4.25.7 respectively, ensuring compatibility with the latest protobuf features and improvements.
  • New Iterator Patterns for Go 1.23+: New auxiliary.go and auxiliary_go123.go files have been added, introducing ErrorEventIterator and ErrorGroupStatsIterator structs with All() methods for Go 1.23+ to simplify iterating over streaming API results.
  • Client Library Refactoring and Standardization: Internal client helper functions have been centralized into a new helpers.go file. Client options now include WithDefaultUniverseDomain and EnableNewAuthLibrary for standardized authentication and endpoint resolution. Default timeouts of 600,000 milliseconds have been added to all API calls for improved reliability.
  • Documentation and Copyright Updates: Copyright years across various files have been updated to 2025. Documentation comments for API requests and resource names have been clarified, including details on regional resource names and the behavior of the Error Reporting service with Cloud Logging.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is an automated update from the librarian tool, primarily focused on upgrading the Go gRPC Protobuf generation. The key changes include updating gRPC service registration functions to use an interface, regenerating Protobuf and gRPC code with newer tool versions, and significant refactoring of the client implementation. Helper functions for executing RPCs and HTTP requests have been centralized, and structured logging using slog has been introduced. Additionally, the documentation and code examples have been improved to reflect support for regional resources and provide better guidance. These changes enhance the library's maintainability, adopt modern Go practices, and appear to be correctly implemented.

@jskeet
Copy link
Contributor

jskeet commented Oct 29, 2025

I believe the errorreporting breaking changes are expected due to changing gRPC plugin. @quartzmo to confirm.

I've created #13263 for the Spanner generation failure.

@quartzmo
Copy link
Member

quartzmo commented Oct 29, 2025

@shollyman PTAL investigate and confirm resolved/non-blocking (or still blocking) for:

  1. apidiff failure in this PR. (Per new info, this is non-blocking and does not require any action.)
  2. build flake in spanner: generation failed #13263

@jskeet
Copy link
Contributor

jskeet commented Oct 29, 2025

Note that the build flake doesn't result in any changes in this PR. It should be fine to merge this regardless of the Spanner failure - if we're happy with the apidiff, of course.

@quartzmo
Copy link
Member

@jskeet We just agreed in standup that the apidiff is non-blocking and can be ignored by the Platform Team. So I guess this is the last time we'll worry about it. If we want a new breaking change check to block merging Generate PRs, we will have to create it or modify apidiff settings.

@shollyman
Copy link
Contributor

current go operator here: apidiff is okay to ignore, and has a known provenance related to underlying gRPC updates. Per previous investigation on the spanner failure, this is also transient and non-impacting.

@parthea parthea merged commit a33d766 into main Oct 29, 2025
9 of 10 checks passed
@parthea parthea deleted the librarian-20251029T071449Z branch October 29, 2025 17:54
@quartzmo
Copy link
Member

I believe the errorreporting breaking changes are expected due to changing gRPC plugin. @quartzmo to confirm.

Confirmed, the errorreporting breaking changes are expected due to changing gRPC plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants