feat(gkerecommender): add new clients #13238

quartzmo · 2025-10-27T18:09:08Z

PiperOrigin-RevId: 805881130

snippet-bot · 2025-10-27T18:09:15Z

Here is the summary of changes.

You are about to add 6 region tags.

internal/generated/snippets/gkerecommender/apiv1/GkeInferenceQuickstartClient/FetchBenchmarkingData/main.go:17, tag gkerecommender_v1_generated_GkeInferenceQuickstart_FetchBenchmarkingData_sync
internal/generated/snippets/gkerecommender/apiv1/GkeInferenceQuickstartClient/FetchModelServerVersions/main.go:17, tag gkerecommender_v1_generated_GkeInferenceQuickstart_FetchModelServerVersions_sync
internal/generated/snippets/gkerecommender/apiv1/GkeInferenceQuickstartClient/FetchModelServers/main.go:17, tag gkerecommender_v1_generated_GkeInferenceQuickstart_FetchModelServers_sync
internal/generated/snippets/gkerecommender/apiv1/GkeInferenceQuickstartClient/FetchModels/main.go:17, tag gkerecommender_v1_generated_GkeInferenceQuickstart_FetchModels_sync
internal/generated/snippets/gkerecommender/apiv1/GkeInferenceQuickstartClient/FetchProfiles/main.go:17, tag gkerecommender_v1_generated_GkeInferenceQuickstart_FetchProfiles_sync
internal/generated/snippets/gkerecommender/apiv1/GkeInferenceQuickstartClient/GenerateOptimizedManifest/main.go:17, tag gkerecommender_v1_generated_GkeInferenceQuickstart_GenerateOptimizedManifest_sync

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

gemini-code-assist · 2025-10-27T18:09:39Z

Summary of Changes

Hello @quartzmo, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a new Go client library for the GKE Recommender API, focusing on the GKE Inference Quickstart service. This addition enables developers to programmatically interact with the GIQ service to retrieve information about models, model servers, and performance profiles, and to generate optimized deployment configurations for machine learning inference on GKE.

Highlights

New Client Library: Introduced a new Go client library for the GKE Recommender API, specifically for the GKE Inference Quickstart (GIQ) service.
API Functionality: The new client provides methods to fetch models, model servers, model server versions, and profiles, as well as to generate optimized deployment manifests and fetch benchmarking data.
Module Integration: The new gkerecommender module has been added to the project's Go workspace configuration (go.work and go.work.sum) and its librarian state.
Generated Code and Documentation: Includes newly generated client code, auxiliary files, documentation (README.md, CHANGES.md, doc.go), GAPIC metadata, and usage examples/snippets for the GKE Inference Quickstart client.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new Go client for the gkerecommender API. The changes primarily consist of adding auto-generated files for this new module. While most of the changes are standard for a new client, I've identified a critical issue in the .librarian/state.yaml configuration file. The remove_regex patterns for the new module are overly aggressive and would likely remove essential client files, which could break the module during build or release processes. This needs to be corrected.

gemini-code-assist · 2025-10-27T18:11:19Z

.librarian/state.yaml

+    remove_regex:
+      - ^internal/generated/snippets/gkerecommender/
+      - ^apiv1/[^/]*_client\.go$
+      - ^apiv1/[^/]*_client_example_go123_test\.go$
+      - ^apiv1/[^/]*_client_example_test\.go$
+      - ^apiv1/auxiliary\.go$
+      - ^apiv1/auxiliary_go123\.go$
+      - ^apiv1/doc\.go$
+      - ^apiv1/gapic_metadata\.json$
+      - ^apiv1/helpers\.go$
+      - ^apiv1/gkerecommenderpb/.*$


The remove_regex configuration for the new gkerecommender module appears to be overly aggressive and seems configured to remove most of the essential generated files for the client. This includes the client implementation, example files, helper files, and protobuf-generated code.

For example:

^apiv1/[^/]*_client\.go$ will match and remove apiv1/gke_inference_quickstart_client.go.

^apiv1/gkerecommenderpb/.*$ will match and remove files under apiv1/gkerecommenderpb/, such as gkerecommender_grpc.pb.go.

This would leave the module in a broken state, making the client unusable. This configuration was likely copied from another module's settings without being correctly adapted for gkerecommender. Please review these regular expressions and adjust them to ensure that only files not intended for the final module are removed.

This is a normal step in regeneration, so I believe it is the correct configuration.

shollyman

As discussed, the remove_regex here seems suspect. Marking this as Do Not Merge for the time being until you have a chance to review with Jon.

quartzmo · 2025-10-27T20:59:05Z

Just for comparison, here's a screenshot from the files that were added/changed for the OwlBot-based locationfinder onboarding PR a few weeks ago:

shollyman

Approving after further discussion.

Also for future me: https://github.com/googleapis/librarian/blob/main/doc/state-schema.md

jskeet · 2025-10-28T09:24:49Z

.librarian/state.yaml

+        service_config: gkerecommender_v1.yaml
+    source_roots:
+      - gkerecommender
+      - internal/generated/


This line is incorrect. I don't know why it's here - I'm looking into it.

Librarian Version: v0.0.0-20251022181450-0ee9437f0ec3 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:313c142a607526975c2313348d975b1efe84e2dd68e768e76354dd3a45577637 <details><summary>aiplatform: 1.109.0</summary> ## [1.109.0](aiplatform/v1.108.0...aiplatform/v1.109.0) (2025-11-06) ### Features * Add order_by to list_events (PiperOrigin-RevId: 827666468) ([4a640b5](4a640b5d)) * add new fields `SUCCESSFULLY_DEPLOYED` and `FAILED_TO_DEPLOY` to `DeploymentStage` (PiperOrigin-RevId: 827616943) ([4a640b5](4a640b5d)) * add new fields `SUCCESSFULLY_DEPLOYED` and `FAILED_TO_DEPLOY` to `DeploymentStage` (PiperOrigin-RevId: 827616855) ([4a640b5](4a640b5d)) * Add EmbedContent method v1 (PiperOrigin-RevId: 823219007) ([612e608](612e608d)) ### Bug Fixes * An existing field `transfer_to_agent` is removed from message `.google.cloud.aiplatform.v1beta1.EventActions` (PiperOrigin-RevId: 826141587) ([4a640b5](4a640b5d)) * updating `enableDirectBigtableAccess` field name in FeatureOnlineStore` (PiperOrigin-RevId: 824609499) ([89b5ea2](89b5ea2f)) * updating `bigtable_metadata` field name in `FeatureView` (PiperOrigin-RevId: 824609499) ([89b5ea2](89b5ea2f)) * updating `bigtable_metadata` field name in `FeatureOnlineStore` (PiperOrigin-RevId: 824609499) ([89b5ea2](89b5ea2f)) ### Documentation * A comment for field `filter` in message `.google.cloud.aiplatform.v1beta1.ListSessionsRequest` is changed (PiperOrigin-RevId: 827666468) ([4a640b5](4a640b5d)) * Remove comments for a non public feature (PiperOrigin-RevId: 826149748) ([4a640b5](4a640b5d)) * fix idle_scaledown_period minimum from 3600 to 300 (5 minutes) (PiperOrigin-RevId: 825640207) ([4a640b5](4a640b5d)) </details> <details><summary>backupdr: 1.5.0</summary> ## [1.5.0](backupdr/v1.4.0...backupdr/v1.5.0) (2025-11-06) ### Features * Adding new workload specific fields for Cloud SQL (PiperOrigin-RevId: 827762328) ([4a640b5](4a640b5d)) * Adding `FetchBackupsForResourceType` API (PiperOrigin-RevId: 827762328) ([4a640b5](4a640b5d)) * Adding `ListDataSourceReferences` API (PiperOrigin-RevId: 827762328) ([4a640b5](4a640b5d)) * Adding `source_resource` fields to Backup resource (PiperOrigin-RevId: 827762328) ([4a640b5](4a640b5d)) </details> <details><summary>chat: 0.16.0</summary> ## [0.16.0](chat/v0.15.1...chat/v0.16.0) (2025-11-06) ### Features * add ROLE_ASSISTANT_MANAGER to the MembershipRole enum in the Membership proto and assistant_managers_allowed to the PermissionSetting (PiperOrigin-RevId: 823185429) ([612e608](612e608d)) ### Documentation * Update field documentations for space.proto and membership.proto (PiperOrigin-RevId: 823185429) ([612e608](612e608d)) </details> <details><summary>dataplex: 1.28.0</summary> ## [1.28.0](dataplex/v1.27.1...dataplex/v1.28.0) (2025-11-06) ### Features * Allow publishing Data Profile scan results to the Dataplex Catalog (PiperOrigin-RevId: 828293199) ([4a640b5](4a640b5d)) * Add GetIamPolicy method for DataProduct resources (PiperOrigin-RevId: 828293199) ([4a640b5](4a640b5d)) * A new message `DataDocumentationSpec` is added representing Data Documentation Spec (PiperOrigin-RevId: 822921010) ([612e608](612e608d)) * A new field `data_documentation_result` is added for Data Documentation Result to message `.google.cloud.dataplex.v1.DataScan` (PiperOrigin-RevId: 822921010) ([612e608](612e608d)) * A new field `data_documentation_result` is added for Data Documentation Result in `.google.cloud.dataplex.v1.DataScanJob` (PiperOrigin-RevId: 822921010) ([612e608](612e608d)) * A new data scan type Data documentation added. (PiperOrigin-RevId: 822921010) ([612e608](612e608d)) * A new message `DataDocumentationResult` is added representing Data Documentation Result (PiperOrigin-RevId: 822921010) ([612e608](612e608d)) * A new field `data_documentation_spec` is added for Data Documentation Spec to message `.google.cloud.dataplex.v1.DataScan` (PiperOrigin-RevId: 822921010) ([612e608](612e608d)) * A new field `data_documentation_spec` is added for Data Documentation Spec to message `.google.cloud.dataplex.v1.DataScanJob` (PiperOrigin-RevId: 822921010) ([612e608](612e608d)) ### Documentation * Update documentation for Catalog SearchEntries filter options, including `parent_entry` and wildcard usage (PiperOrigin-RevId: 828293199) ([4a640b5](4a640b5d)) * A comment for field `resource` in message `.google.cloud.dataplex.v1.DataSource` is changed (PiperOrigin-RevId: 822921010) ([612e608](612e608d)) * A comment for message `DataScan` is changed (PiperOrigin-RevId: 822921010) ([612e608](612e608d)) </details> <details><summary>dialogflow: 1.71.0</summary> ## [1.71.0](dialogflow/v1.70.0...dialogflow/v1.71.0) (2025-11-06) ### Features * Expose skip_empty_event_based_suggestion in ConversationProfile (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) * Added Vertex extension tool support to v2/v2beta1 (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) * Context references added to conversation for dynamic data ingestion (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) * Expose debug info field in ConversationProfile (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) * Added support for AI Coach feature (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) * Improved generator quota management (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) * add Agent Assist Generator Evaluation feature (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) * A new field &#39;security_settings&#39; is added to GenerateStatelessSuggestionRequest (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) * add a turn complete signal to BidiStreamingAnalyzeContent (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) * Added support for Build Your Own Assist feature (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) * Expose flexible safety filter change, rai_settings in ConversationProfile (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) * Added tool support for AI Coach feature (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) ### Documentation * minor formatting (PiperOrigin-RevId: 823067257) ([612e608](612e608d)) * Updated comments for the `SuggestionInput` message, documenting how it is used with tools (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) * update documentation for transcription language code configuration (PiperOrigin-RevId: 822692160) ([84cf55a](84cf55a9)) </details> <details><summary>edgenetwork: 1.3.0</summary> ## [1.3.0](edgenetwork/v1.2.7...edgenetwork/v1.3.0) (2025-11-06) ### Features * A new field `remote_peering_network_type` is added to message `google.cloud.edgenetwork.v1.Interconnect` (PiperOrigin-RevId: 824727309) ([89b5ea2](89b5ea2f)) * A new field `peering_type` is added to message `google.cloud.edgenetwork.v1.InterconnectAttachment` (PiperOrigin-RevId: 824727309) ([89b5ea2](89b5ea2f)) </details> <details><summary>gkerecommender: 0.1.0</summary> ## [0.1.0](gkerecommender/v0.0.0...gkerecommender/v0.1.0) (2025-11-06) ### Features * add new clients (#13238) (PiperOrigin-RevId: 805881130) ([8f604ff](8f604ff6)) </details> <details><summary>maps: 1.26.0</summary> ## [1.26.0](maps/v1.25.0...maps/v1.26.0) (2025-11-06) ### Features * Add Review.visitDate field to indicate when the review author visited (PiperOrigin-RevId: 822750099) ([84cf55a](84cf55a9)) * Add Place.consumerAlert field for suspicious review activity (PiperOrigin-RevId: 822750099) ([84cf55a](84cf55a9)) </details> <details><summary>networkmanagement: 1.21.0</summary> ## [1.21.0](networkmanagement/v1.20.1...networkmanagement/v1.21.0) (2025-11-06) ### Features * add rpc `VpcFlowLogsService.QueryOrgVpcFlowLogsConfigs` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add fields `cross_project_metadata`, `target_resource_state`, `network`, and `subnet` to message `VpcFlowLogsConfig` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * Enable organization-level support for VPC Flow Logs (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add enum value `AbortInfo.Cause.GOOGLE_MANAGED_SERVICE_AMBIGUOUS_ENDPOINT` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add field `service_uri` to message `Endpoint.CloudRunRevisionEndpoint` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add http additional_bindings (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add enum `VpcFlowLogsConfig.CrossProjectMetadata` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add message `Endpoint.SingleEdgeResponse` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add service `OrganizationVpcFlowLogsService` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add enum values `NO_ROUTE_FROM_EXTERNAL_IPV6_SOURCE_TO_PRIVATE_IPV6_ADDRESS`, `TRAFFIC_FROM_HYBRID_ENDPOINT_TO_INTERNET_DISALLOWED`, `NO_MATCHING_NAT64_GATEWAY`, `LOAD_BALANCER_BACKEND_IP_VERSION_MISMATCH`, and `NO_KNOWN_ROUTE_FROM_NCC_NETWORK_TO_DESTINATION` to `DropInfo.Cause` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add enum `DeliverInfo.GoogleServiceType` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add field `policy_priority` to message `NetworkInfo` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add enum `Status` to message `InstanceInfo` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add enum value `RouteInfo.NextHopType.SECURE_WEB_PROXY_GATEWAY` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add field `google_service_type` to message `DeliverInfo` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add enum `VpcFlowLogsConfig.TargetResourceState` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) * add field `running` to message `InstanceInfo` (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) ### Documentation * Various documentation and comment improvements, Enable organization-level support for VPC Flow Logs (PiperOrigin-RevId: 825895694) ([4a640b5](4a640b5d)) </details> <details><summary>networkservices: 0.6.0</summary> ## [0.6.0](networkservices/v0.5.1...networkservices/v0.6.0) (2025-11-06) ### Features * Add support for LbEdgeExtension resource in NetworkServices API (PiperOrigin-RevId: 827499725) ([4a640b5](4a640b5d)) </details> <details><summary>saasplatform: 0.1.0</summary> ## [0.1.0](saasplatform/v0.0.0...saasplatform/v0.1.0) (2025-11-06) ### Features * add new clients (#13307) (PiperOrigin-RevId: 791799161) ([fa28dd8](fa28dd89)) </details> <details><summary>shopping: 1.3.0</summary> ## [1.3.0](shopping/v1.2.1...shopping/v1.3.0) (2025-11-06) ### Bug Fixes * An existing field `contains_custom_rules` is removed from message `.google.shopping.merchant.datasources.v1.PrimaryProductDataSource` (PiperOrigin-RevId: 826368950) ([4a640b5](4a640b5d)) ### Documentation * update documentation for datasources (PiperOrigin-RevId: 826368950) ([4a640b5](4a640b5d)) </details>

feat(gkerecommender): add new clients

ef5fadf

PiperOrigin-RevId: 805881130

quartzmo requested a review from a team as a code owner October 27, 2025 18:09

gemini-code-assist bot reviewed Oct 27, 2025

View reviewed changes

shollyman reviewed Oct 27, 2025

View reviewed changes

shollyman added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2025

shollyman removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2025

shollyman approved these changes Oct 27, 2025

View reviewed changes

quartzmo merged commit 8f604ff into googleapis:main Oct 27, 2025
13 checks passed

quartzmo deleted the librarian-onboard-gkerecommender branch October 27, 2025 21:38

jskeet reviewed Oct 28, 2025

View reviewed changes

This was referenced Oct 28, 2025

prototype(internal/librariangen): results of including "go mod init" and "go mod tidy" in postprocessor #13220

Closed

feat(gkerecommender): new client(s) #13240

Closed

cloud-sdk-librarian-robot mentioned this pull request Nov 6, 2025

chore: librarian release pull request: 20251106T080659Z #13319

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(gkerecommender): add new clients #13238

feat(gkerecommender): add new clients #13238

Uh oh!

quartzmo commented Oct 27, 2025

Uh oh!

snippet-bot bot commented Oct 27, 2025

Uh oh!

gemini-code-assist bot commented Oct 27, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Oct 27, 2025

Uh oh!

quartzmo Oct 27, 2025 •

edited

Loading

Uh oh!

shollyman left a comment

Uh oh!

quartzmo commented Oct 27, 2025

Uh oh!

shollyman left a comment

Uh oh!

Uh oh!

jskeet Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat(gkerecommender): add new clients #13238

feat(gkerecommender): add new clients #13238

Uh oh!

Conversation

quartzmo commented Oct 27, 2025

Uh oh!

snippet-bot bot commented Oct 27, 2025

Uh oh!

gemini-code-assist bot commented Oct 27, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

quartzmo Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

shollyman left a comment

Choose a reason for hiding this comment

Uh oh!

quartzmo commented Oct 27, 2025

Uh oh!

shollyman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jskeet Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

quartzmo Oct 27, 2025 •

edited

Loading