Skip to content

Conversation

@epall
Copy link
Contributor

@epall epall commented Jun 4, 2018

oauth2client is not even a required dependency now, so this check throws a confusing error message

This sort of fixes #521, but I still can't import apiclient.discovery without having oauth2client installed:

>>> from apiclient import discovery
Traceback (most recent call last):
  File "/Users/epall/projects/google-api-python-client/googleapiclient/sample_tools.py", line 32, in <module>
    from oauth2client import client
ModuleNotFoundError: No module named 'oauth2client'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/epall/projects/google-api-python-client/apiclient/__init__.py", line 13, in <module>
    from googleapiclient import sample_tools
  File "/Users/epall/projects/google-api-python-client/googleapiclient/sample_tools.py", line 36, in <module>
    raise ImportError('googleapiclient.sample_tools requires oauth2client. Please install oauth2client and try again.')
ImportError: googleapiclient.sample_tools requires oauth2client. Please install oauth2client and try again.
>>>

oauth2client is not even a required dependency now, so this check throws a confusing error message
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 4, 2018
@epall
Copy link
Contributor Author

epall commented Jun 4, 2018

I signed the CLA!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 4, 2018
@atc0m
Copy link

atc0m commented Jun 4, 2018

Please merge this as soon as possible! Thank you!

@theacodes theacodes merged commit 0821aa2 into googleapis:master Jun 4, 2018
@theacodes
Copy link
Contributor

Thanks, @epall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discovery checks for removed oauth2client dependency

4 participants