Drop oauth2client dependency #499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 27, 2018 13:34
Executing tox in the project directory is not the same of what is being executed in travis-ci This cause problems when replacing oauth2client library by google-auth in the setup.py because oauth2client is mandatory for tests, and travis was not installing oauth2client if it is not in the setup.py. Also it is good to keep the consistency of the test environments.
Fix import error message for file_cache The import can failed not only because we are using oauth2client>4.0.0 but also when we are using google-auth
Use local googleapiclient _helpers
oauth2client is deprecated, use google-auth instead Closes googleapis#437
googlebot
added
the
cla: yes
theacodes
changed the title
theacodes
approved these changes
Apr 27, 2018
theacodes
changed the title
theacodes
approved these changes
May 31, 2018
|
Thank you, everyone, for finalizing this! ✨ ✨ ✨ |
This was referenced Jun 3, 2018
adjackura
pushed a commit
to GoogleCloudPlatform/compute-image-tools
that referenced
this pull request
Jun 5, 2018
Fix broken API after googleapis/google-api-python-client#499
dotlambda
added a commit
to dotlambda/nixpkgs
that referenced
this pull request
Mar 25, 2025
Merged
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oauth2client is deprecated, use google-auth instead
Closes #437