Skip to content

build(deps): bump docker/docker to v28.0.0+incompatible #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

luhring
Copy link
Contributor

@luhring luhring commented Feb 25, 2025

And adjust for breaking API changes.

And adjust for breaking API changes.

Signed-off-by: Dan Luhring <[email protected]>
@jonjohnsonjr jonjohnsonjr merged commit 098045d into google:main Feb 25, 2025
16 checks passed
luhring added a commit to wolfi-dev/wolfictl that referenced this pull request Feb 26, 2025
luhring added a commit to wolfi-dev/wolfictl that referenced this pull request Feb 26, 2025
@azdagron
Copy link

Excited to see this has been addressed! Is there a release planned soon that includes this?

@sonatard
Copy link

@jonjohnsonjr @imjasonh @mattmoor Do you have any plans for a release? I'm using this module indirectly, but every time I update go.mod, I keep running into this error.

@picatz
Copy link

picatz commented Apr 15, 2025

🤷 FWIW, I'm also running into an issue that looks related to this PR via a Dependabot update that didn't touch github.com/google/go-containerregistry:

Bumps the golang group with 2 updates: github.com/moby/buildkit and golang.org/x/exp.

Updates github.com/moby/buildkit from 0.20.2 to 0.21.0
...

$ go build -mod=vendor ./cmd/scan 
# github.com/google/go-containerregistry/pkg/v1/daemon
vendor/github.com/google/go-containerregistry/pkg/v1/daemon/options.go:40:9: cannot use client.NewClientWithOpts(client.FromEnv) (value of type *client.Client) as Client value in return statement: *client.Client does not implement Client (wrong type for method ImageHistory)
                have ImageHistory(context.Context, string, ...client.ImageHistoryOption) ([]image.HistoryResponseItem, error)
                want ImageHistory(context.Context, string) ([]image.HistoryResponseItem, error)

098045d#diff-517aa68b1408ed1ee9038fed40728dd8333b78d49efba0e0a873ccb5c2301644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants