-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Skip bundle_size job for merge_group event #8032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Size Change: -2 B (0%) Total Size: 12.5 MB ℹ️ View Unchanged
|
Collaborator
Author
Collaborator
Author
#7395 added the bundle_size job for all CI events, but it turns out that preact/compressed-size-action doesn't support the merge_group action (https://github.com/preactjs/compressed-size-action/blob/2a937a1dd255ef04f3ee3611816b630873f5faa3/src/index.js#L37). This has been broken since the job was introduced (e.g. here it is failing for the merge of the job itself: https://github.com/google-gemini/gemini-cli/actions/runs/17476553727/job/49637776974)
5756ba9 to
0541910
Compare
mattKorwel
approved these changes
Sep 8, 2025
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
skeshive
pushed a commit
that referenced
this pull request
Sep 8, 2025
SandyTao520
pushed a commit
that referenced
this pull request
Sep 10, 2025
thacio
added a commit
to thacio/auditaria
that referenced
this pull request
Oct 1, 2025
giraffe-tree
pushed a commit
to giraffe-tree/gemini-cli
that referenced
this pull request
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


TLDR
Don't run bundle size check on merge_group event.
Dive Deeper
#7395 added the bundle_size job for all CI events, but it turns out that preact/compressed-size-action doesn't support the merge_group event (https://github.com/preactjs/compressed-size-action/blob/2a937a1dd255ef04f3ee3611816b630873f5faa3/src/index.js#L37).
This has been broken since the job was introduced (e.g. here it is failing for the merge of the job itself:
https://github.com/google-gemini/gemini-cli/actions/runs/17476553727/job/49637776974)
Reviewer Test Plan
n/a
Testing Matrix
n/a
Linked issues / bugs
In the interests of #3694 to get main to green.