-
Notifications
You must be signed in to change notification settings - Fork 8k
fix(ui): disable input prompt during tool confirmation #7935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): disable input prompt during tool confirmation #7935
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Lyonk71, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the user experience by correctly managing the state of the input prompt. It ensures that users cannot inadvertently type commands when the application is awaiting confirmation for tool actions, thereby preventing potential confusion and erroneous inputs.
Highlights
- Input Prompt Disablement: The pull request resolves an issue where the user input prompt remained active during tool confirmation. This was fixed by reintroducing streamingState validation to the isInputActive flag, ensuring the prompt is only enabled when the application is in an Idle or Responding state.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Warning Gemini encountered an error creating the review. You can try again by commenting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overview
This pull request addresses an issue where the user input prompt remained active while the application was awaiting user confirmation for tool actions.
The root cause was the accidental omission of
streamingState
validation from theisInputActive
flag during a recent refactor. This change restores the original "whitelist" logic, ensuring the input prompt is only enabled when the application is in anIdle
orResponding
state.Reviewer Test Plan
Add 3 files named a.txt, b.txt, 3.txt each that contain the words "hello world" each using the write file tool.
displayed, attempt to type in the input prompt.
active again once the tool execution is complete.
Testing Matrix
Linked issues / bugs
Fixes #7912