Skip to content

Conversation

Lyonk71
Copy link
Contributor

@Lyonk71 Lyonk71 commented Sep 7, 2025

Overview

This pull request addresses an issue where the user input prompt remained active while the application was awaiting user confirmation for tool actions.

The root cause was the accidental omission of streamingState validation from the isInputActive flag during a recent refactor. This change restores the original "whitelist" logic, ensuring the input prompt is only enabled when the application is in an Idle or Responding state.

Reviewer Test Plan

  1. Run a command that requires tool confirmation, for example:
    Add 3 files named a.txt, b.txt, 3.txt each that contain the words "hello world" each using the write file tool.
  2. While the confirmation prompt ("Do you want to run this command?") is
    displayed, attempt to type in the input prompt.
  3. Verify that the input prompt is disabled and does not accept any text.
  4. Confirm the tool action and verify that the input prompt becomes
    active again once the tool execution is complete.

Testing Matrix

🍏 🪟 🐧
npm run
npx
Docker
Podman - -
Seatbelt - -

Linked issues / bugs

Fixes #7912

@Lyonk71 Lyonk71 requested a review from a team as a code owner September 7, 2025 19:24
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Lyonk71, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience by correctly managing the state of the input prompt. It ensures that users cannot inadvertently type commands when the application is awaiting confirmation for tool actions, thereby preventing potential confusion and erroneous inputs.

Highlights

  • Input Prompt Disablement: The pull request resolves an issue where the user input prompt remained active during tool confirmation. This was fixed by reintroducing streamingState validation to the isInputActive flag, ensuring the prompt is only enabled when the application is in an Idle or Responding state.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-cli gemini-cli bot added kind/bug Something isn't working priority/p0 Critical and urgent (e.g., critical security vulnerability, major breakage). area/ux Improves the CLI's usability, performance, interactive features, and documentation. labels Sep 7, 2025
Copy link
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

Copy link
Collaborator

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacob314 jacob314 enabled auto-merge September 7, 2025 19:54
@jacob314 jacob314 added this pull request to the merge queue Sep 7, 2025
Merged via the queue into google-gemini:main with commit 4693137 Sep 7, 2025
20 checks passed
@Lyonk71 Lyonk71 deleted the fix/7912-disable-input-tool-messages branch September 8, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux Improves the CLI's usability, performance, interactive features, and documentation. kind/bug Something isn't working priority/p0 Critical and urgent (e.g., critical security vulnerability, major breakage).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The input prompt is now active while confirming tool responses
2 participants