Use IdeClient directly instead of config.ideClient #7627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @scidomino, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the application's interaction with the IDE client by centralizing access through the IdeClient.getInstance() singleton. The primary goal is to simplify the architecture and improve maintainability by removing redundant client management within the Config class, which in turn facilitates easier integration with UI components.
Highlights
- Direct IdeClient Usage: The pull request refactors the codebase to directly use
IdeClient.getInstance()instead of relying onconfig.ideClient. This change leverages the singleton nature ofIdeClientand removes the need forConfigto maintain its own copy. - Simplified Configuration Initialization: By removing
IdeClientfrom theConfigclass and moving its connection logic intoConfig.initialize(), the setup process for React components that depend on the IDE client is simplified. - Codebase Cleanup: Various files across
a2a-server,cli, andcorepackages have been updated to reflect the directIdeClientusage, including removinggetIdeClientmethods from mock configurations and updating command implementations and tests.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase to use IdeClient.getInstance() directly, removing the need to pass the IdeClient through the config object. This is a good simplification. The changes across the various files are consistent with this goal. However, I've found a critical issue in packages/cli/src/ui/hooks/slashCommandProcessor.ts where a useEffect hook is updated incorrectly, leading to a memory leak because the cleanup function is never registered. I've provided a detailed comment and a suggested fix for this issue.
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
gemini-cli
bot
added
the
status/need-issue
scidomino
force-pushed
the
tomm_ide
branch
2 times, most recently
from
35e57ff to
9697ac9
Compare
scidomino
removed
the
status/need-issue
gemini-cli
bot
added
kind/bug
scidomino
force-pushed
the
tomm_ide
branch
2 times, most recently
from
9fac8e0 to
ae194bb
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request is a solid refactoring that simplifies access to IdeClient by removing it from the config object and instead using the static IdeClient.getInstance() method. This change improves decoupling and is applied consistently across the codebase, including updates to tests and mocks. I've identified one area of concern regarding potential unhandled promise rejections when setting up an event listener and have provided a suggestion to make the implementation more robust.
|
Seeing a bug where running /ide enable does not enable the integration as expected. Given the error message, seems likely .connect() isnt being called or we're not waiting for the connection to become active Repro steps: Run /ide disable and restart CLI |
scidomino
force-pushed
the
tomm_ide
branch
2 times, most recently
from
4ac03bf to
63a796d
Compare
There was a subtle check-then-act bug in IdeClient.getInstance(). This was causing two instances of IdeClient to be created. I fixed it and now it works as expected. |
|
I believe these E2E test failures are unrelated. |
scidomino
force-pushed
the
tomm_ide
branch
2 times, most recently
from
c6ad698 to
d8c80d6
Compare
NTaylorMullen
approved these changes
Sep 4, 2025
There was a problem hiding this comment.
Approving to unblock, should wait for an approval from @skeshive
skeshive
approved these changes
Sep 4, 2025
scidomino
dismissed
Amnat-auyana1998’s stale review
If you want to request changes, you have to specify what they are.
acoliver
pushed a commit
to acoliver/llxprt-code
that referenced
this pull request
Sep 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
IdeClient.getInstance is already a single global instance so there's no value in config keeping it's own copy.
Dive Deeper
I'm moving config.initialize() into the react code and this change will simplify things a lot since react needs the ideClient to be ready in a bunch of places.
Reviewer Test Plan
Start with
"ideMode": false,and use/ide enableand/ide disable.Start with
"ideMode": true,and do the same.Testing Matrix
Linked issues / bugs
For #4544