chore(e2e): Stabilize e2e test by adding a more descriptive prompt #7599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @adamfweidman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on enhancing the reliability of an existing end-to-end test. By refining the input prompt and updating the expected output assertions, the change aims to eliminate intermittent test failures and ensure consistent test results, thereby improving the overall stability of the test suite.
Highlights
- Test Stability Improvement: The primary goal of this pull request is to stabilize a frequently failing end-to-end test (
utf-bom-encoding.test.ts) by addressing the root cause of its flakiness. - Prompt Refinement: The prompt used within the e2e test has been made more descriptive, aiming to elicit a more consistent and predictable response from the system under test.
- Assertion Updates: The test's assertions have been modified to align with the new, more specific prompt, now expecting keywords like "googlesearch" and "21" instead of the less reliable "terminal".
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to stabilize an e2e test by making the prompt more descriptive. While the prompt change is a good step, the new assertions introduced to validate the response are brittle. Specifically, they rely on a magic number ('21') from image OCR and a conversational keyword ('googlesearch'), both of which can easily change and cause test flakiness. My feedback focuses on removing these fragile assertions to improve the long-term stability of the test, in line with the PR's objective.
adamfweidman
force-pushed
the
adamfw/stabilize-e2e-utf
branch
from
710424c to
5b59e8f
Compare
gemini-cli
bot
added
the
status/need-issue
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
thacio
added a commit
to thacio/auditaria
that referenced
this pull request
Sep 3, 2025
…re descriptive prompt (google-gemini#7599)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
This e2e test frequently failed when looking for the
terminalkeyword.With the new change the test passed 5 times in a row when run locally.
Reviewer Test Plan
Run npm run test:e2e -- --test-name-pattern "utf-bom-encoding.test.ts" X number of times locally
Testing Matrix