fix(ide): use port number for server port file instead of vscode pid #7368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @skeshive, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a robustness issue in the IDE server's communication mechanism by changing how its port file is named. Previously, the file name relied on the parent process ID ('process.ppid'), which could lead to conflicts in environments with multiple VS Code instances. The change now uses the actual server port number in the file name, ensuring uniqueness and preventing race conditions, thereby making CLI interaction with the IDE server more reliable.
Highlights
- Improved Port File Naming: The IDE server's port file naming convention has been updated from using 'process.ppid' to the actual assigned port number (e.g., 'gemini-ide-server-${port}.json'). This ensures unique file names for each server instance.
- Enhanced Robustness: This change resolves potential race conditions and conflicts that could occur when multiple VS Code instances shared the same parent process ID, leading to more reliable CLI communication with the IDE server.
- Deferred Port File Creation: The creation of the port file is now deferred until after the IDE server has successfully started and a unique port has been assigned, ensuring the file accurately reflects the active server instance.
- Dependency Updates: The 'NOTICES.txt' file has been updated to reflect various dependency version changes and associated license information, as part of routine maintenance.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors the IDE server to use the server's port number for the port file name instead of the parent process ID. This is a solid improvement that resolves a potential race condition with multiple VS Code instances. The code changes are clear and the tests have been updated accordingly. I've found one potential issue regarding state management after the server is stopped, which could lead to incorrect behavior.
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
|
If you have this write both files with different name formats, the change can be submitted in a backwards compatible way. |
gemini-cli
bot
added
kind/bug
cornmander
approved these changes
Sep 1, 2025
thacio
added a commit
to thacio/auditaria
that referenced
this pull request
Sep 1, 2025
…e instead of vscode pid (google-gemini#7368)
davideast
pushed a commit
to davideast/gemini-cli
that referenced
this pull request
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR
This change modifies the naming convention for the IDE server's port file. Previously, the filename was based on the parent process ID (
process.ppid). Now, it uses the actual port the server is listening on.Compatibility Note: These changes are backwards compatible since we still write the file with the vscode pid.
Dive Deeper
The previous implementation used
gemini-ide-server-${process.ppid}.jsonto store the server's port and workspace information. However, theppidcan be the same for multiple VS Code extension host processes, leading to a race condition where different server instances could overwrite the same port file.This PR fixes the issue by deferring the port file creation until after the server has successfully started and has been assigned a unique port. The filename is now
gemini-ide-server-${port}.json. This guarantees a unique file for each running server instance, preventing conflicts and improving the overall stability of the IDE companion.Linked Issues
#6848