-
Notifications
You must be signed in to change notification settings - Fork 8k
chore(ci): Ensure triage workflows are consistent #6108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
b750c14
to
54ad44a
Compare
There's still work to mitigate all possible injection attacks, but this prevents _shell_ injection attacks.
54ad44a
to
353cb89
Compare
Code Coverage Summary
CLI Package - Full Text Report
Core Package - Full Text Report
For detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
cornmander
approved these changes
Aug 13, 2025
thacio
added a commit
to thacio/auditaria
that referenced
this pull request
Aug 13, 2025
mahimashanware
pushed a commit
to mahimashanware/gemini-cli
that referenced
this pull request
Aug 18, 2025
JeongJaeSoon
pushed a commit
to JeongJaeSoon/gemini-cli
that referenced
this pull request
Aug 21, 2025
Gosling-dude
pushed a commit
to Gosling-dude/gemini-cli
that referenced
this pull request
Aug 23, 2025
involvex
pushed a commit
to involvex/gemini-cli
that referenced
this pull request
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still work to mitigate all possible injection attacks, but this prevents shell injection attacks.
TLDR
These are some best practice recommendations for ensuring untrusted inputs aren't available as arbitrary execution in bash scripts. It also ensures our YAML is always interpreted as expected with proper quoting and consistent blocks.