-
Notifications
You must be signed in to change notification settings - Fork 8k
Revert "[ide-mode] Thread active file through to system prompt" #4308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 222e362.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a full revert of a previous change (PR #4264) that aimed to thread active file context from IDE mode into the system prompt. The decision to revert is in favor of exploring a different approach for handling this functionality, effectively removing the previously added IDE mode context from the system prompt generation.
Highlights
- Revert IDE Mode Context: The primary change is the removal of code that dynamically added active file and cursor position information to the system prompt when the application was running in IDE mode. This functionality, originally introduced in PR #4264, is now fully undone.
- Simplified
getCoreSystemPrompt
Signature: ThegetCoreSystemPrompt
function no longer requires aConfig
object as a parameter, simplifying its interface and removing its dependency on the application's configuration. - Test Suite Updates: Corresponding test files have been updated to reflect the simplified
getCoreSystemPrompt
signature, removing related mocking and test cases that previously validated the IDE mode context integration.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts a previous change that added IDE mode context to the system prompt. The changes cleanly remove the feature by updating the getCoreSystemPrompt
function signature and all its call sites in both application code and tests. The revert appears to be correct and complete, and I found no issues during the review.
Code Coverage Summary
CLI Package - Full Text Report
Core Package - Full Text Report
For detailed HTML reports, please see the 'coverage-reports-22.x' artifact from the main CI run. |
Reverts #4264 in favor of a different approach