-
Notifications
You must be signed in to change notification settings - Fork 8k
update /bug
to new slash command arch
#4246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update /bug
to new slash command arch
#4246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @haroldmciver-go, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors the command handling mechanism within the CLI by migrating existing and introducing new slash commands to a more modular and maintainable CommandService
architecture. This change centralizes command definitions and logic, improving testability and future extensibility.
Highlights
- Command Architecture Migration: The
/bug
slash command has been refactored and migrated to a new, modularCommandService
architecture, making it a standalone module and removing its legacy implementation fromslashCommandProcessor.ts
. - New Slash Commands: Two new slash commands,
/extensions
(to list active CLI extensions) and/tools
(to list available Gemini CLI tools with an option for descriptions), have been introduced as standalone modules within the new command architecture. - Centralized Command Handling: The
slashCommandProcessor.ts
has been streamlined by delegating the handling of/bug
,/extensions
, and/tools
commands to theCommandService
, centralizing command definitions and execution. - Comprehensive Unit Testing: Dedicated unit tests have been added for the new
bugCommand
,extensionsCommand
, andtoolsCommand
modules, ensuring their functionality, proper integration, and adherence to the new architectural standards.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully refactors the /bug
command to the new slash command architecture, along with /extensions
and /tools
. This is a great improvement, moving command logic out of the monolithic slashCommandProcessor
into dedicated, testable modules. The new command implementations and their corresponding unit tests are well-written.
I've identified one high-severity issue related to test stability in bugCommand.test.ts
, where using live process
properties can lead to flaky tests across different environments. I've suggested mocking these values to ensure deterministic test runs.
Overall, this is a solid refactoring that improves the maintainability and testability of the codebase.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
6222e85
to
fffc1c2
Compare
Co-authored-by: Abhi <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Abhi <[email protected]>
Co-authored-by: Abhi <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Abhi <[email protected]>
Co-authored-by: Abhi <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Abhi <[email protected]>
Co-authored-by: Abhi <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Abhi <[email protected]>
Co-authored-by: Abhi <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Abhi <[email protected]>
Co-authored-by: Abhi <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Abhi <[email protected]>
Co-authored-by: Abhi <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Abhi <[email protected]>
TLDR
Refactored the
/bug
slash command to adhere to a new architecture. Integrating it with the CommandService, and slashCommandProcessor and adding unit testDive Deeper
This pr migrates the legacy slash command
/bug
to the new CommandService Architecture. The command has been refactored to a standalone module and removes it from the legacy handler in slashCommandProcessor.tsReviewer Test Plan
Run
/bug
. The terminal should open the link to Gemini CLI github to create an issue.Testing Matrix