-
Notifications
You must be signed in to change notification settings - Fork 8k
[ide-mode] Stream notifications when the active file changes #4147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the VSCode IDE companion server by introducing support for resumable Model Context Protocol (MCP) sessions and enabling real-time streaming of the active file in the VS Code editor. These changes allow for more persistent and interactive communication between the IDE and MCP clients, providing a richer development experience.
Highlights
- Resumable Sessions: The Model Context Protocol (MCP) server now supports resumable sessions. This allows clients to establish a session, disconnect, and then reconnect using a session ID to continue their interaction, improving client-server communication persistence.
- Active File Streaming: A new MCP tool named
streamIDEState
has been added to the VSCode IDE server. This tool enables real-time streaming of the currently active file's path in the VS Code editor to connected MCP clients, sending a notification whenever the active editor changes. - Server Refactoring for Session Management: The server's request handling logic has been refactored to manage multiple
StreamableHTTPServerTransport
instances, one for each active session. This change facilitates the new resumable session capability and enables dedicated streaming channels for notifications.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces session management to the VSCode IDE companion server, allowing for resumable sessions and a new tool to stream the active file path. A critical resource leak was identified due to improper handling of event listeners within sessions, along with high-severity issues related to an incorrect tool description and an inconsistent data structure in notifications. Suggestions have been provided to fix these issues to improve the stability and correctness of the implementation.
Code Coverage Summary
CLI Package - Full Text Report
Core Package - Full Text Report
For detailed HTML reports, please see the 'coverage-reports-22.x' artifact from the main CI run. |
Co-authored-by: Scott Densmore <[email protected]>
…gemini#4147) Co-authored-by: Scott Densmore <[email protected]>
Co-authored-by: Scott Densmore <[email protected]>
…gemini#4147) Co-authored-by: Scott Densmore <[email protected]>
…gemini#4147) Co-authored-by: Scott Densmore <[email protected]>
…gemini#4147) Co-authored-by: Scott Densmore <[email protected]>
TLDR
In the VSCode extension-based MCP server, send notifications when the active file changes.
Dive Deeper
Returns structured data with { filePath } for now, but we can add additional listeners and data in a follow-up.
Also now supports resumable sessions.
Reviewer Test Plan
Test it with the inspector or any MCP client.
Testing Matrix
Linked issues / bugs
Progress on #3906