Skip to content

fix: fix starttls-option-key not exist #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jakezhu9 merged 1 commit into from
Nov 13, 2023
Merged

fix: fix starttls-option-key not exist #340

jakezhu9 merged 1 commit into from
Nov 13, 2023

Conversation

@textworld
Copy link
Contributor

@textworld textworld commented Nov 9, 2023

#339 fix

@jakezhu9
Copy link
Member

jakezhu9 commented Nov 12, 2023

@textworld 感谢贡献🎉 有两个小问题可以改改吗

  1. 你的提交里包含了对resources/template/theme/default-theme-anatole的修改，这部分应该是不需要的？
  2. 你似乎没有正确配置git的用户名和邮箱，导致commit没有和你的github账号链接上

@textworld
Copy link
Contributor Author

textworld commented Nov 13, 2023 •
edited
Loading

@textworld 感谢贡献🎉 有两个小问题可以改改吗

  1. 你的提交里包含了对resources/template/theme/default-theme-anatole的修改，这部分应该是不需要的？
  2. 你似乎没有正确配置git的用户名和邮箱，导致commit没有和你的github账号链接上
    @jakezhu9
  1. 是由于未将子模块更新至最新的commit导致，已修复
  2. 已修改

jakezhu9
jakezhu9 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@jakezhu9 jakezhu9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@jakezhu9 jakezhu9 merged commit a7249f3 into go-sonic:master Nov 13, 2023
@jakezhu9 jakezhu9 mentioned this pull request Nov 16, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakezhu9 jakezhu9 jakezhu9 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@textworld @jakezhu9