Skip to content

Conversation

@gibmat
Copy link
Contributor

@gibmat gibmat commented Oct 18, 2025

Fixes Or Enhances

While 32bit systems are becoming rarer, Debian still fully supports armhf. On such systems, TestLuhnChecksumValidation fails because some of the integer values overflow without an explicit cast to int64.

# github.com/go-playground/validator/v10 [github.com/go-playground/validator/v10.test]
./validator_test.go:13914:4: cannot use 586824160825533338 (untyped int constant) as int value in struct literal (overflows)
./validator_test.go:13917:4: cannot use 586824160825533328 (untyped int constant) as int value in struct literal (overflows)
./validator_test.go:13919:4: cannot use 10000000116 (untyped int constant) as int value in struct literal (overflows)
./validator_test.go:13921:4: cannot use 10000000117 (untyped int constant) as int value in struct literal (overflows)

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@gibmat gibmat requested a review from a team as a code owner October 18, 2025 14:17
@coveralls
Copy link

Coverage Status

coverage: 73.73%. remained the same
when pulling d85a8af on gibmat:fix-32bit-test-failures
into 2d3af3d on go-playground:master.

Copy link
Contributor

@nodivbyzero nodivbyzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodivbyzero nodivbyzero merged commit 6a38036 into go-playground:master Oct 20, 2025
8 checks passed
@gibmat gibmat deleted the fix-32bit-test-failures branch October 20, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants