Skip to content

Conversation

@duyquang6
Copy link
Contributor

Fixes Or Enhances

fix #1466

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@duyquang6 duyquang6 requested a review from a team as a code owner September 17, 2025 16:03
@duyquang6 duyquang6 force-pushed the fix/should-panic-required-if-duplicate-fieldname branch from cb7ec54 to 52ecdf6 Compare September 17, 2025 16:03
@coveralls
Copy link

coveralls commented Sep 17, 2025

Coverage Status

coverage: 73.684% (+0.007%) from 73.677%
when pulling 7458d8a on duyquang6:fix/should-panic-required-if-duplicate-fieldname
into 6905468 on go-playground:master.

@nodivbyzero
Copy link
Contributor

Looks good to me. Just a couple of follow-ups:

  1. We should probably add the same logic to required_unless.
  2. Please update doc.go to reflect the new behavior.

@duyquang6
Copy link
Contributor Author

@nodivbyzero

  • Updated doc.go
  • required_unless is a little bit different, I found that it work fine with duplicate params, so I just add testcase for it

duyquang6 and others added 2 commits September 25, 2025 12:20
@nodivbyzero nodivbyzero merged commit 94e89f0 into go-playground:master Oct 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: required_if with multiple values on the same field unexpected behavior

3 participants