Skip to content

Conversation

nodivbyzero
Copy link
Contributor

Fixes Or Enhances

Based on the https://github.com/go-playground/validator?tab=readme-ov-file#maintenance-and-support-for-sdk-major-versions

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@nodivbyzero nodivbyzero requested a review from a team as a code owner April 16, 2025 19:01
@coveralls
Copy link

coveralls commented Apr 16, 2025

Coverage Status

coverage: 73.655% (+0.002%) from 73.653%
when pulling bb82cbd on nodivbyzero:github-action-support-2-major-go-versions
into 8032f40 on go-playground:master.

@nodivbyzero
Copy link
Contributor Author

@deankarn @zemzale Can you please review this PR?
This change is required to address high-severity vulnerabilities in golang.org/x/crypto.

zemzale
zemzale previously approved these changes Apr 30, 2025
@deankarn
Copy link
Contributor

We only officially support the latest two versions, but is there any reason to not test the older version as well until if starts failing?

@nodivbyzero
Copy link
Contributor Author

@deankarn I'm just trying to understand the reasoning - why test the older version if it's no longer officially supported?
Are we planning to address any breaking issues if tests start failing on that version?

@nodivbyzero
Copy link
Contributor Author

@deankarn
I've added a new workflow that triggers on pushes to the master branch and runs tests using Go versions 1.21 through 1.24.
bb82cbd

@nodivbyzero nodivbyzero requested a review from zemzale May 27, 2025 19:33
@nodivbyzero
Copy link
Contributor Author

@deankarn @zemzale
Whenever you get a chance, could you please review this PR?

Copy link
Contributor

@deankarn deankarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodivbyzero nodivbyzero merged commit 53c4d6b into go-playground:master Jul 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants