Align required_without with usage shown in the docs #1324
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmfrees
changed the title
|
Why is the request closed? As far as I understand, the error has not been fixed. |
I must've deleted my fork. Let me bring it back. Maybe we can actually get this merged 😅 |
1 task
|
Thanks for pointing this out @longing-esv. I brought it back in another PR since I was not allowed to re-open this one. |
nodivbyzero
pushed a commit
that referenced
this pull request
Apr 28, 2025
…1422) ## Fixes Or Enhances Resolves #617 Fixes `required_without` so that it aligns with the stated contract and usage examples. The [docs](https://pkg.go.dev/github.com/go-playground/validator/v10#hdr-Required_Without) valid usage to be: ``` // require the field if the Field1 is not present: Usage: required_without=Field1 // require the field if the Field1 or Field2 is not present: Usage: required_without=Field1 Field2 ``` However, as show in this issue: #617, you can only use `required_without` on multiple fields like: ```golang type Test struct { Field1 string `validator:required_without=Field2,required_without=Field3" ... } ``` This PR aligns the behavior of the `required_without` validator such that you can also use it as shown in the example: ```golang type Test struct { Field1 string `validator:required_without=Field2 Field3" ... } ``` **Make sure that you've checked the boxes below before you submit PR:** - [x] Tests exist or have been written that cover this particular change. Note: Sorry for the duplication of #1324. I was cleaning up my profile and deleted my fork before it could be merged. @go-playground/validator-maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Resolves #617
Fixes
required_withoutso that it aligns with the stated contract and usage examples.The docs valid usage to be:
However, as show in this issue: #617, you can only use
required_withouton multiple fields like:This PR aligns the behavior of the
required_withoutvalidator such that you can also use it as shown in the example:Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers