Group function update #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 3, 2017 11:41
Removed Group and replaced with: GroupWithExisting, GroupWithNone and GroupWithMore. Group handled all three in one, but was confusing and was constantly refering back to the source to remember how it worked; now it is clear.
- GroupWithExisting wa too long for a default behaviour function. - Updated README version as this is a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
Groupfunction handled 3 different scenarios:.Group("/users")- group with existing middleware.Group("/users", nil)- group but retain no middleware.Group("/users", MoreMiddleware)- group, retain existing and add MoreMiddlewareThis was confusing and even I was always referring to the function to remember what it all did so here is how it works now.
.Group("/users")- group with existing middleware.GroupWithNone("/users")- group but retain no middleware..GroupWithMore("/users", MoreMiddleware)- group, retain existing and add MoreMiddleware