perf: enhance default tag for pointer type #48
Conversation
hnimtadd
force-pushed
the
enhance-default-tag
branch
from
fab3464 to
f68af3e
Compare
hnimtadd
force-pushed
the
enhance-default-tag
branch
from
f68af3e to
b1cd38c
Compare
| // 2. Attempting to set its underlying value | ||
| // Try to convert the parameter string to the appropriate primitive type | ||
| // that the pointer references (e.g., *string, *int, *bool) | ||
| value, err := mold.GetPrimitiveValue(fl.Field().Type().Elem().Kind(), fl.Param()) |
There was a problem hiding this comment.
Instead of the new GetPrimitiveValue function could we change the function signature of setValue to accept reflect.Value and string(the param) and recursively call it dereferencing the pointer.
This would avoid needing the new function I think and addition of the new error types as well.
There was a problem hiding this comment.
I found some time to do and test this today #49
everything should be working as expected as of Release 4.5.1 https://github.com/go-playground/mold/releases/tag/v4.5.1
|
I very much appreciate the PR it helped visualize the issue and by providing relevant tests :) Closing as #49 resolved this is a slightly different way and is now part of release https://github.com/go-playground/mold/releases/tag/v4.5.1 |
3 participants
No description provided.