This repository was archived by the owner on Oct 30, 2025. It is now read-only.
sliceop{,/f64s}: introduce generics sliceop #931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move and generalize code from sliceop/f64s into sliceop. name old time/op new time/op delta Take/Len=2-8 2.69ns ± 1% 2.71ns ± 2% +0.75% (p=0.043 n=18+18) Take/Len=4-8 3.18ns ± 1% 3.23ns ± 3% +1.27% (p=0.005 n=19+20) Take/Len=8-8 3.83ns ± 1% 3.73ns ± 1% -2.69% (p=0.000 n=20+19) Take/Len=128-8 44.1ns ± 4% 35.9ns ± 2% -18.61% (p=0.000 n=20+20) Take/Len=1024-8 337ns ± 2% 280ns ± 6% -16.73% (p=0.000 n=19+20) Take/Len=1048576-8 1.37ms ± 3% 1.31ms ± 5% -3.97% (p=0.000 n=19+20) name old alloc/op new alloc/op delta Take/Len=2-8 0.00B 0.00B ~ (all equal) Take/Len=4-8 0.00B 0.00B ~ (all equal) Take/Len=8-8 0.00B 0.00B ~ (all equal) Take/Len=128-8 0.00B 0.00B ~ (all equal) Take/Len=1024-8 0.00B 0.00B ~ (all equal) Take/Len=1048576-8 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta Take/Len=2-8 0.00 0.00 ~ (all equal) Take/Len=4-8 0.00 0.00 ~ (all equal) Take/Len=8-8 0.00 0.00 ~ (all equal) Take/Len=128-8 0.00 0.00 ~ (all equal) Take/Len=1024-8 0.00 0.00 ~ (all equal) Take/Len=1048576-8 0.00 0.00 ~ (all equal) Updates go-hep#868.
name old time/op new time/op delta Take/Len=2-8 2.95ns ± 2% 2.96ns ± 2% ~ (p=0.952 n=20+20) Take/Len=4-8 3.43ns ± 1% 3.67ns ± 1% +6.96% (p=0.000 n=20+19) Take/Len=8-8 3.92ns ± 2% 4.17ns ± 1% +6.31% (p=0.000 n=19+20) Take/Len=128-8 36.4ns ± 2% 35.6ns ± 2% -2.21% (p=0.000 n=20+20) Take/Len=1024-8 278ns ± 5% 271ns ± 2% -2.29% (p=0.001 n=17+19) Take/Len=1048576-8 1.27ms ± 2% 0.67ms ± 6% -46.97% (p=0.000 n=19+20) name old alloc/op new alloc/op delta Take/Len=2-8 0.00B 0.00B ~ (all equal) Take/Len=4-8 0.00B 0.00B ~ (all equal) Take/Len=8-8 0.00B 0.00B ~ (all equal) Take/Len=128-8 0.00B 0.00B ~ (all equal) Take/Len=1024-8 0.00B 0.00B ~ (all equal) Take/Len=1048576-8 0.00B 0.00B ~ (all equal) name old allocs/op new allocs/op delta Take/Len=2-8 0.00 0.00 ~ (all equal) Take/Len=4-8 0.00 0.00 ~ (all equal) Take/Len=8-8 0.00 0.00 ~ (all equal) Take/Len=128-8 0.00 0.00 ~ (all equal) Take/Len=1024-8 0.00 0.00 ~ (all equal) Take/Len=1048576-8 0.00 0.00 ~ (all equal)
Codecov Report
@@ Coverage Diff @@
## main #931 +/- ##
=======================================
Coverage 73.77% 73.77%
=======================================
Files 409 410 +1
Lines 48789 48793 +4
=======================================
+ Hits 35994 35998 +4
Misses 10511 10511
Partials 2284 2284
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move and generalize code from sliceop/f64s into sliceop.
Updates #868.