columnToFieldIndex: Improve performance #406
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in the same spirit as #347
We found that the function
columnToFieldIndex
was inefficient from a CPU usage POV, but more importantly created ton of objects for the GC.Analyzing real world usage of gorp in a proprietary API server, we were able to reduce overall memory allocs by ~50% and bytes allocated by ~20% with this patch.
This PR:
columnToFieldIndex
reflectx
to implementcolumnToFieldIndex
. reduce call to reflect.Type.FieldByName #347 tries to implement it locally, butreflectx
does exactly what we need here, and has built-in caching based on thereflect.Type
. We would need to replicate a few things into gorp if the dependency is not acceptable.Micro-benchmark results: