Fix WebAuthn error checking #36219
Merged
Fix WebAuthn error checking #36219
+14
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
Member
Author
|
I have tested and passkey login still works. Errors also display as expected when I do not provide a passkey. |
delvh
approved these changes
Dec 20, 2025
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
Dec 21, 2025
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 22, 2025
* giteaofficial/main: Fix WebAuthn error checking (go-gitea#36219) [skip ci] Updated translations via Crowdin refactor: extract helper functions from SearchIssues (go-gitea#36158) [skip ci] Updated translations via Crowdin Revert "[skip ci] Updated translations via Crowdin" Closed milestones with no issues now show as 100% completed (go-gitea#36220) Show edit page confirmation dialog on tree view file change (go-gitea#36130) Fix regression in writing authorized principals (go-gitea#36213) [skip ci] Updated translations via Crowdin Convert locale files from ini to json format (go-gitea#35489) Bump crowdin/github-action from 1 to 2 (go-gitea#36204) Bump appleboy/git-push-action from 0.0.3 to 1.0.0 (go-gitea#36194) Fix labeler config for stylelint (go-gitea#36199) Add `modifies/dependencies` label to dependabot (go-gitea#36206) Add date to "No Contributions" tooltip (go-gitea#36190) Revert "Bump alpine to 3.23 (go-gitea#36185)" (go-gitea#36202)
Collaborator
|
I was unable to create a backport for 1.25. @silverwind, please send one manually. 🍵 |
GiteaBot
added
the
backport/manual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #36216
Now
detectWebAuthnSupportreturns the error type and lets the caller decide whether they callwebAuthnErrorand show the error. It no longer shows the error during page load when the user has not even interacted with the feature.The bug affects all users on HTTP, so I think a quick fix release for this might be good.