Migrate to urfave v3 #34510
Migrate to urfave v3 #34510
Conversation
ensure flags don't carry state through tests
patch smtp idflag persisting
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
|
For future: I don't mind you/someone else fixing/editing stuff but a heads up would be nice - especially on a WIP where half of it is hacks to get tests to pass. Either way thanks for some cleanups on this. |
|
Sorry, I saw it had no progress for long time, and we had some discussions about the strange "config" behavior in discord, so I just tried to fix the problems. Will ask ahead next time. |
|
No problem, I appreciate your effort regardless. :) |
| docs, err := ctx.App.ToMarkdown() | ||
| if ctx.Bool("man") { | ||
| docs, err = ctx.App.ToMan() | ||
| func runDocs(_ context.Context, cmd *cli.Command) error { |
There was a problem hiding this comment.
For reviewers: Double check if the docs are correct as the generation is weird, but it might not have the same issue as with tea due to custom help.
GiteaBot
added
lgtm/need 1
wxiaoguang
added
type/refactoring
| Usage: "Generate self-signed certificate", | ||
| Description: `Generate a self-signed X.509 certificate for a TLS server. | ||
| // cmdCert represents the available cert sub-command. | ||
| func cmdCert() *cli.Command { |
There was a problem hiding this comment.
Why use a function instead of a variable here.
There was a problem hiding this comment.
Variables keep their state, which isn't an issue during regular usage, but it's annoying for tests.
It completely breaks flags if the command stores them as they keep their state between runs leading to cases where test which expects no --port flag for example has a --port flag set from previous run.
update copyright date and remove traceline
migrate cli to urfave v3
add more cli tests