Decorrelates openapi registration from server #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EwenQuim
force-pushed
the
decorrelates-openapi-registration-from-server
branch
2 times, most recently
from
fcbee50 to
2697662
Compare
EwenQuim
commented
Dec 11, 2024
EwenQuim
commented
Dec 11, 2024
EwenQuim
force-pushed
the
decorrelates-openapi-registration-from-server
branch
from
2697662 to
dadcb76
Compare
ccoVeille
reviewed
Dec 11, 2024
EwenQuim
force-pushed
the
decorrelates-openapi-registration-from-server
branch
2 times, most recently
from
71bb9cb to
c833e87
Compare
EwenQuim
force-pushed
the
decorrelates-openapi-registration-from-server
branch
from
ce950ef to
0ed8902
Compare
Member
Author
|
Ready for review |
dylanhitt
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to make
RegisterOpenAPIOperationindependent fromfuego.Server. Doing so, we might reuse this function for other routers, like Gin #241 or Echo.RegisterOpenAPIOperationonly needed OpenAPI details, not the whole router anyway! What we had before was a demonstration of implementation leak. With aServerstruct that have many fields, we are locking ourselves where it wasn't necessary.This PR is backward-compatible! No test have change except for semantics. OMG I love Go for making this refactoring so easy...